-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix(v9/e2e-tests): Fix various e2e tests #18226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 'sentry.sveltekit.navigation.type': 'link', | ||
| 'sentry.sveltekit.navigation.from': '/', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: PR assumes navigation.type changes from 'goto' to 'link' for redirects in SvelteKit 2.41.0 without evidence.
Severity: HIGH | Confidence: 0.90
🔍 Detailed Analysis
The pull request modifies test expectations for navigation.type in the sveltekit-2-svelte-5 e2e tests, assuming that upgrading @sveltejs/kit from ^2.21.3 to 2.41.0 will change redirect navigation types from 'goto' to 'link'. This assumption lacks evidence (no changelog, issue, or documentation reference) and creates an inconsistency with the sveltekit-2 test suite, which expects 'goto' for the same redirect navigations. If SvelteKit 2.41.0 does not change this behavior, the updated tests will fail, as programmatic redirects are documented to be 'goto'.
💡 Suggested Fix
Verify if SvelteKit 2.41.0 actually changes navigation.type for redirects from 'goto' to 'link'. Adjust test expectations accordingly or revert if no change is confirmed.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location:
dev-packages/e2e-tests/test-applications/sveltekit-2-svelte-5/tests/performance.test.ts#L319-L320
Potential issue: The pull request modifies test expectations for `navigation.type` in
the `sveltekit-2-svelte-5` e2e tests, assuming that upgrading `@sveltejs/kit` from
`^2.21.3` to `2.41.0` will change redirect navigation types from `'goto'` to `'link'`.
This assumption lacks evidence (no changelog, issue, or documentation reference) and
creates an inconsistency with the `sveltekit-2` test suite, which expects `'goto'` for
the same redirect navigations. If SvelteKit 2.41.0 does not change this behavior, the
updated tests will fail, as programmatic redirects are documented to be `'goto'`.
Did we get this right? 👍 / 👎 to inform future reviews.
Reference_id: 2721742
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not relevant.
size-limit report 📦
|
Lms24
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for going through all of these test fails! 🙏
Contains backports of: #17979, #17665, #18056
Does not backport fixes for optional e2e test apps.