feat: update eslint to v8

dev-packages/browser-integration-tests/utils/replayHelpers.ts

@@ -115,7 +115,6 @@ export function collectReplayRequests(
   const replayEvents: ReplayEvent[] = [];
   const replayRecordingSnapshots: RecordingSnapshot[] = [];
 
-  // eslint-disable-next-line @typescript-eslint/no-floating-promises
   const promise = page.waitForResponse(res => {
     const req = res.request();
 

dev-packages/node-core-integration-tests/suites/tracing/sample-rand-propagation/server.js

@@ -24,7 +24,7 @@ app.use(cors());
 
 app.get('/check', (req, res) => {
   const appPort = getPortAppIsRunningOn(app);
-  // eslint-disable-next-line no-undef
+
   fetch(`http://localhost:${appPort}/bounce`)
     .then(r => r.json())
     .then(bounceRes => {

dev-packages/node-core-integration-tests/suites/tracing/sample-rate-propagation/no-tracing-enabled/server.js

@@ -23,7 +23,7 @@ app.use(cors());
 
 app.get('/check', (req, res) => {
   const appPort = getPortAppIsRunningOn(app);
-  // eslint-disable-next-line no-undef
+
   fetch(`http://localhost:${appPort}/bounce`)
     .then(r => r.json())
     .then(bounceRes => {

dev-packages/node-core-integration-tests/suites/tracing/sample-rate-propagation/tracesSampleRate-0/server.js

@@ -24,7 +24,7 @@ app.use(cors());
 
 app.get('/check', (req, res) => {
   const appPort = getPortAppIsRunningOn(app);
-  // eslint-disable-next-line no-undef
+
   fetch(`http://localhost:${appPort}/bounce`)
     .then(r => r.json())
     .then(bounceRes => {

dev-packages/node-core-integration-tests/suites/tracing/sample-rate-propagation/tracesSampleRate/server.js

@@ -24,7 +24,7 @@ app.use(cors());
 
 app.get('/check', (req, res) => {
   const appPort = getPortAppIsRunningOn(app);
-  // eslint-disable-next-line no-undef
+
   fetch(`http://localhost:${appPort}/bounce`)
     .then(r => r.json())
     .then(bounceRes => {

dev-packages/node-core-integration-tests/suites/tracing/sample-rate-propagation/tracesSampler-with-otel-http-instrumentation/server.js

@@ -30,7 +30,6 @@ app.get('/check', (req, res) => {
   Sentry.startSpan({ name: 'check-endpoint' }, async () => {
     const appPort = getPortAppIsRunningOn(app);
     try {
-      // eslint-disable-next-line no-undef
       const response = await fetch(`http://localhost:${appPort}/bounce`);
       const bounceRes = await response.json();
       // eslint-disable-next-line no-console

dev-packages/node-integration-tests/suites/public-api/LocalVariables/local-variables-out-of-app-default.js

@@ -1,5 +1,3 @@
-/* eslint-disable no-unused-vars */
-
 const Sentry = require('@sentry/node');
 const { loggingTransport } = require('@sentry-internal/node-integration-tests');
 

dev-packages/node-integration-tests/suites/public-api/LocalVariables/local-variables-out-of-app.js

@@ -1,5 +1,3 @@
-/* eslint-disable no-unused-vars */
-
 const Sentry = require('@sentry/node');
 const { loggingTransport } = require('@sentry-internal/node-integration-tests');
 

dev-packages/node-integration-tests/suites/tracing/apollo-graphql/scenario-mutation.js

@@ -39,5 +39,4 @@ async function run() {
   );
 }
 
-// eslint-disable-next-line @typescript-eslint/no-floating-promises
 run();

dev-packages/node-integration-tests/suites/tracing/apollo-graphql/scenario-query.js

@@ -33,5 +33,4 @@ async function run() {
   );
 }
 
-// eslint-disable-next-line @typescript-eslint/no-floating-promises
 run();

dev-packages/node-integration-tests/suites/tracing/apollo-graphql/useOperationNameForRootSpan/scenario-invalid-root-span.js

@@ -30,5 +30,4 @@ async function run() {
   });
 }
 
-// eslint-disable-next-line @typescript-eslint/no-floating-promises
 run();

dev-packages/node-integration-tests/suites/tracing/apollo-graphql/useOperationNameForRootSpan/scenario-multiple-operations-many.js

@@ -39,5 +39,4 @@ async function run() {
   );
 }
 
-// eslint-disable-next-line @typescript-eslint/no-floating-promises
 run();

dev-packages/node-integration-tests/suites/tracing/apollo-graphql/useOperationNameForRootSpan/scenario-multiple-operations.js

@@ -41,5 +41,4 @@ async function run() {
   );
 }
 
-// eslint-disable-next-line @typescript-eslint/no-floating-promises
 run();

dev-packages/node-integration-tests/suites/tracing/apollo-graphql/useOperationNameForRootSpan/scenario-mutation.js

@@ -43,5 +43,4 @@ async function run() {
   );
 }
 
-// eslint-disable-next-line @typescript-eslint/no-floating-promises
 run();

dev-packages/node-integration-tests/suites/tracing/apollo-graphql/useOperationNameForRootSpan/scenario-no-operation-name.js

@@ -37,5 +37,4 @@ async function run() {
   );
 }
 
-// eslint-disable-next-line @typescript-eslint/no-floating-promises
 run();

dev-packages/node-integration-tests/suites/tracing/apollo-graphql/useOperationNameForRootSpan/scenario-query.js

@@ -37,5 +37,4 @@ async function run() {
   );
 }
 
-// eslint-disable-next-line @typescript-eslint/no-floating-promises
 run();

dev-packages/node-integration-tests/suites/tracing/mongodb/scenario.js

@@ -44,5 +44,4 @@ async function run() {
   );
 }
 
-// eslint-disable-next-line @typescript-eslint/no-floating-promises
 run();

dev-packages/node-integration-tests/suites/tracing/mongoose/scenario.js

@@ -45,5 +45,4 @@ async function run() {
   );
 }
 
-// eslint-disable-next-line @typescript-eslint/no-floating-promises
 run();

dev-packages/node-integration-tests/suites/tracing/postgres/scenario-native.js

@@ -44,5 +44,4 @@ async function run() {
   );
 }
 
-// eslint-disable-next-line @typescript-eslint/no-floating-promises
 run();

dev-packages/node-integration-tests/suites/tracing/postgres/scenario.js

@@ -42,5 +42,4 @@ async function run() {
   );
 }
 
-// eslint-disable-next-line @typescript-eslint/no-floating-promises
 run();

dev-packages/node-integration-tests/suites/tracing/postgresjs/scenario.js

@@ -58,5 +58,4 @@ async function run() {
   );
 }
 
-// eslint-disable-next-line @typescript-eslint/no-floating-promises
 run();

dev-packages/node-integration-tests/suites/tracing/redis-cache/scenario-ioredis.js

@@ -42,5 +42,4 @@ async function run() {
   );
 }
 
-// eslint-disable-next-line @typescript-eslint/no-floating-promises
 run();

dev-packages/node-integration-tests/suites/tracing/redis-cache/scenario-redis-4.js

@@ -42,5 +42,4 @@ async function run() {
   );
 }
 
-// eslint-disable-next-line @typescript-eslint/no-floating-promises
 run();

dev-packages/node-integration-tests/suites/tracing/redis/scenario-ioredis.js

@@ -33,5 +33,4 @@ async function run() {
   );
 }
 
-// eslint-disable-next-line @typescript-eslint/no-floating-promises
 run();

dev-packages/node-integration-tests/suites/tracing/sample-rand-propagation/server.js

@@ -21,7 +21,7 @@ app.use(cors());
 
 app.get('/check', (req, res) => {
   const appPort = getPortAppIsRunningOn(app);
-  // eslint-disable-next-line no-undef
+
   fetch(`http://localhost:${appPort}/bounce`)
     .then(r => r.json())
     .then(bounceRes => {

dev-packages/node-integration-tests/suites/tracing/sample-rate-propagation/no-tracing-enabled/server.js

@@ -20,7 +20,7 @@ app.use(cors());
 
 app.get('/check', (req, res) => {
   const appPort = getPortAppIsRunningOn(app);
-  // eslint-disable-next-line no-undef
+
   fetch(`http://localhost:${appPort}/bounce`)
     .then(r => r.json())
     .then(bounceRes => {

dev-packages/node-integration-tests/suites/tracing/sample-rate-propagation/tracesSampleRate-0/server.js

@@ -21,7 +21,7 @@ app.use(cors());
 
 app.get('/check', (req, res) => {
   const appPort = getPortAppIsRunningOn(app);
-  // eslint-disable-next-line no-undef
+
   fetch(`http://localhost:${appPort}/bounce`)
     .then(r => r.json())
     .then(bounceRes => {

dev-packages/node-integration-tests/suites/tracing/sample-rate-propagation/tracesSampleRate/server.js

@@ -21,7 +21,7 @@ app.use(cors());
 
 app.get('/check', (req, res) => {
   const appPort = getPortAppIsRunningOn(app);
-  // eslint-disable-next-line no-undef
+
   fetch(`http://localhost:${appPort}/bounce`)
     .then(r => r.json())
     .then(bounceRes => {

dev-packages/node-integration-tests/suites/tracing/sample-rate-propagation/tracesSampler/server.js

@@ -23,7 +23,7 @@ app.use(cors());
 
 app.get('/check', (req, res) => {
   const appPort = getPortAppIsRunningOn(app);
-  // eslint-disable-next-line no-undef
+
   fetch(`http://localhost:${appPort}/bounce`)
     .then(r => r.json())
     .then(bounceRes => {

package.json

@@ -121,7 +121,7 @@
     "deepmerge": "^4.2.2",
     "downlevel-dts": "~0.11.0",
     "es-check": "^7.2.1",
-    "eslint": "7.32.0",
+    "eslint": "8.57.0",
     "jsdom": "^21.1.2",
     "lerna": "7.1.1",
     "madge": "8.0.0",

packages/angular/src/index.ts

@@ -1,3 +1,6 @@
+// import/export got a false positive, and affects most of our index barrel files
+// can be removed once following issue is fixed: https://github.com/import-js/eslint-plugin-import/issues/703
+/* eslint-disable import/export */
 export type { ErrorHandlerOptions } from './errorhandler';
 
 export * from '@sentry/browser';

packages/astro/src/index.client.ts

@@ -1,3 +1,6 @@
+// import/export got a false positive, and affects most of our index barrel files
+// can be removed once following issue is fixed: https://github.com/import-js/eslint-plugin-import/issues/703
+/* eslint-disable import/export */
 export * from '@sentry/browser';
 
 // Override the browserTracingIntegration with the custom Astro version

packages/astro/src/index.types.ts

@@ -1,3 +1,5 @@
+// import/export got a false positive, and affects most of our index barrel files
+// can be removed once following issue is fixed: https://github.com/import-js/eslint-plugin-import/issues/703
 /* eslint-disable import/export */
 
 // We export everything from both the client part of the SDK and from the server part.

packages/aws-serverless/src/integration/instrumentation-aws-lambda/instrumentation.ts

@@ -298,7 +298,6 @@ export class AwsLambdaInstrumentation extends InstrumentationBase<AwsLambdaInstr
     return function patchedHandler(
       this: never,
       // The event can be a user type, it truly is any.
-      // eslint-disable-next-line @typescript-eslint/no-explicit-any
       event: any,
       context: Context,
       callback: Callback,
@@ -414,7 +413,6 @@ export class AwsLambdaInstrumentation extends InstrumentationBase<AwsLambdaInstr
   private _traceForceFlush(tracerProvider: TracerProvider) {
     if (!tracerProvider) return undefined;
 
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     let currentProvider: any = tracerProvider;
 
     if (typeof currentProvider.getDelegate === 'function') {
@@ -442,7 +440,6 @@ export class AwsLambdaInstrumentation extends InstrumentationBase<AwsLambdaInstr
   private _metricForceFlush(meterProvider: MeterProvider) {
     if (!meterProvider) return undefined;
 
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     const currentProvider: any = meterProvider;
 
     if (typeof currentProvider.forceFlush === 'function') {

packages/aws-serverless/test/sdk.test.ts

@@ -18,7 +18,6 @@ const mockScope = {
 };
 
 vi.mock('@sentry/node', async () => {
-  // eslint-disable-next-line @typescript-eslint/consistent-type-imports
   const original = await vi.importActual('@sentry/node');
   return {
     ...original,

packages/aws-serverless/test/utils.test.ts

@@ -3,7 +3,6 @@ import { eventContextExtractor, getAwsTraceData } from '../src/utils';
 
 const mockExtractContext = vi.fn();
 vi.mock('@opentelemetry/api', async () => {
-  // eslint-disable-next-line @typescript-eslint/consistent-type-imports
   const actualApi = await vi.importActual('@opentelemetry/api');
   return {
     ...actualApi,

packages/browser-utils/src/metrics/browserMetrics.ts

@@ -15,11 +15,11 @@ import {
 import { WINDOW } from '../types';
 import { trackClsAsStandaloneSpan } from './cls';
 import {
-  type PerformanceLongAnimationFrameTiming,
   addClsInstrumentationHandler,
   addLcpInstrumentationHandler,
   addPerformanceInstrumentationHandler,
   addTtfbInstrumentationHandler,
+  type PerformanceLongAnimationFrameTiming,
 } from './instrument';
 import { trackLcpAsStandaloneSpan } from './lcp';
 import { resourceTimingToSpanAttributes } from './resourceTiming';

packages/browser/src/profiling/UIProfiler.ts

@@ -1,6 +1,5 @@
-import type { Client, ContinuousProfiler, ProfileChunk, Span } from '@sentry/core';
+import type { Client, ContinuousProfiler, ProfileChunk, ProfileChunkEnvelope, Span } from '@sentry/core';
 import {
-  type ProfileChunkEnvelope,
   createEnvelope,
   debug,
   dsnToString,

packages/browser/src/tracing/linkedTraces.ts

@@ -1,6 +1,5 @@
-import type { Client, PropagationContext, Span } from '@sentry/core';
+import type { Client, PropagationContext, Span, SpanContextData } from '@sentry/core';
 import {
-  type SpanContextData,
   debug,
   getCurrentScope,
   getRootSpan,

packages/browser/test/profiling/UIProfiler.test.ts

@@ -3,8 +3,8 @@
  */
 
 import * as Sentry from '@sentry/browser';
-import { type Span, debug } from '@sentry/core';
-import { type Mock, afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
+import { debug, type Span } from '@sentry/core';
+import { afterEach, beforeEach, describe, expect, it, type Mock, vi } from 'vitest';
 import type { BrowserOptions } from '../../src/index';
 
 function getBaseOptionsForTraceLifecycle(sendMock: Mock<any>, enableTracing = true): BrowserOptions {

packages/cloudflare/src/durableobject.ts

@@ -1,10 +1,10 @@
 /* eslint-disable @typescript-eslint/unbound-method */
 import {
-  type Scope,
   captureException,
   flush,
   getClient,
   isThenable,
+  type Scope,
   SEMANTIC_ATTRIBUTE_SENTRY_OP,
   SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
   startSpan,

packages/cloudflare/test/copy-execution-context.test.ts

@@ -1,4 +1,4 @@
-import { type Mocked, describe, expect, it, vi } from 'vitest';
+import { describe, expect, it, type Mocked, vi } from 'vitest';
 import { copyExecutionContext } from '../src/utils/copyExecutionContext';
 
 describe('Copy of the execution context', () => {

packages/core/src/client.ts

@@ -44,7 +44,7 @@ import { merge } from './utils/merge';
 import { checkOrSetAlreadyCaught, uuid4 } from './utils/misc';
 import { parseSampleRate } from './utils/parseSampleRate';
 import { prepareEvent } from './utils/prepareEvent';
-import { type PromiseBuffer, makePromiseBuffer, SENTRY_BUFFER_FULL_ERROR } from './utils/promisebuffer';
+import { makePromiseBuffer, type PromiseBuffer, SENTRY_BUFFER_FULL_ERROR } from './utils/promisebuffer';
 import { reparentChildSpans, shouldIgnoreSpan } from './utils/should-ignore-span';
 import { showSpanDropWarning } from './utils/spanUtils';
 import { rejectedSyncPromise } from './utils/syncpromise';
@@ -884,13 +884,13 @@ export abstract class Client<O extends ClientOptions = ClientOptions> {
    */
   public emit(hook: 'idleSpanEnableAutoFinish', span: Span): void;
 
-  /*
+  /**
    * Fire a hook event for envelope creation and sending. Expects to be given an envelope as the
    * second argument.
    */
   public emit(hook: 'beforeEnvelope', envelope: Envelope): void;
 
-  /*
+  /**
    * Fire a hook indicating that stack frame metadata should be applied to the event passed to the hook.
    */
   public emit(hook: 'applyFrameMetadata', event: Event): void;
@@ -920,7 +920,7 @@ export abstract class Client<O extends ClientOptions = ClientOptions> {
    */
   public emit(hook: 'postprocessEvent', event: Event, hint?: EventHint): void;
 
-  /*
+  /**
    * Fire a hook event after sending an event. Expects to be given an Event as the
    * second argument.
    */

packages/core/src/tracing/openai/streaming.ts

@@ -8,12 +8,12 @@ import {
   GEN_AI_RESPONSE_TOOL_CALLS_ATTRIBUTE,
 } from '../ai/gen-ai-attributes';
 import { RESPONSE_EVENT_TYPES } from './constants';
-import type { OpenAIResponseObject } from './types';
-import {
-  type ChatCompletionChunk,
-  type ChatCompletionToolCall,
-  type ResponseFunctionCall,
-  type ResponseStreamingEvent,
+import type {
+  ChatCompletionChunk,
+  ChatCompletionToolCall,
+  OpenAIResponseObject,
+  ResponseFunctionCall,
+  ResponseStreamingEvent,
 } from './types';
 import {
   isChatCompletionChunk,

packages/core/src/transports/base.ts

@@ -14,8 +14,8 @@ import {
   forEachEnvelopeItem,
   serializeEnvelope,
 } from '../utils/envelope';
-import { type PromiseBuffer, makePromiseBuffer, SENTRY_BUFFER_FULL_ERROR } from '../utils/promisebuffer';
-import { type RateLimits, isRateLimited, updateRateLimits } from '../utils/ratelimit';
+import { makePromiseBuffer, type PromiseBuffer, SENTRY_BUFFER_FULL_ERROR } from '../utils/promisebuffer';
+import { isRateLimited, type RateLimits, updateRateLimits } from '../utils/ratelimit';
 
 export const DEFAULT_TRANSPORT_BUFFER_SIZE = 64;