Skip to content

Conversation

@andreiborza
Copy link
Member

No description provided.

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. We should have a slack alert (or open a GH issue) if merge master into develop fails to merge

@github-actions
Copy link
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 9,037 - 8,699 +4%
GET With Sentry 1,738 19% 1,725 +1%
GET With Sentry (error only) 6,117 68% 6,119 -0%
POST Baseline 1,186 - 1,197 -1%
POST With Sentry 587 49% 589 -0%
POST With Sentry (error only) 1,051 89% 1,052 -0%
MYSQL Baseline 3,311 - 3,275 +1%
MYSQL With Sentry 500 15% 484 +3%
MYSQL With Sentry (error only) 2,699 82% 2,709 -0%

View base workflow run

@andreiborza andreiborza merged commit 1df6ff9 into develop Nov 24, 2025
201 checks passed
@andreiborza andreiborza deleted the manual-sync-dev branch November 24, 2025 21:26
andreiborza added a commit that referenced this pull request Nov 25, 2025
It's often hard to notice when our Gitflow merge PRs fail due to merge
conflicts and the longer they are open the harder it will be to fix
these merge conflicts eventually.

e.g. #18314

This is an attempt at notifying us better when these happen by creating
an issue in our repo (did not actually test this yet so we might have to
go through some iterations 😅).

Idea by Abhi:
#18317 (review)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants