Skip to content

Conversation

@Lms24
Copy link
Member

@Lms24 Lms24 commented Nov 25, 2025

Fixes a bug reported in #18318 where

Sentry.logger.info('Test message', { key: 'value' }, { scope: customScope });

would not forward the customScope but instead drop the log all together.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2025

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 8,796 - 9,175 -4%
GET With Sentry 1,667 19% 1,794 -7%
GET With Sentry (error only) 5,971 68% 6,286 -5%
POST Baseline 1,180 - 1,216 -3%
POST With Sentry 579 49% 603 -4%
POST With Sentry (error only) 1,028 87% 1,076 -4%
MYSQL Baseline 3,262 - 3,398 -4%
MYSQL With Sentry 440 13% 501 -12%
MYSQL With Sentry (error only) 2,709 83% 2,753 -2%

View base workflow run

@Lms24 Lms24 merged commit 3b0728f into develop Nov 26, 2025
144 checks passed
@Lms24 Lms24 deleted the lms/fix-node-logs-custom-scope branch November 26, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants