meta(changelog): Update changelog for 10.29.0 #18407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This upgrades our internal eslint config to use v8. Theoretically this is considered a breaking change. Since this is an internal `@sentry-internal/*` package, we can release this in a non-breaking fashion With v8 couple of changes came. Some of them are affecting us, which required file changes: - [simple-import-sort/import](https://www.npmjs.com/package/eslint-plugin-simple-import-sort) got couple of fixes - "Unused eslint-disable directive": Unused "eslint-disable" comments are now detected and marked as error - [import/export](https://www.npmjs.com/package/eslint-plugin-import) got a false positive, which affects most of our index barrel files (I didn't want to disable it entirely, so I added a global disable in each affected barrel file) - tracked here: import-js/eslint-plugin-import#703 ## Merge checks - [ ] Rebased before merge to get the latest changes updated with the new version
Pinning these versions as the latest seems to introduce breaking changes that blocks our CI Closes #18391
[Gitflow] Merge master into develop
This fix will check for a `msg` field in the logger call (https://getpino.io/#/docs/api?id=messagekey-string) if there was no message string passed: ```ts logger.info("This was always logged"); logger.info({ msg: "This now gets logged too" }); // This pr adds support for this ``` closes #18381 closes https://linear.app/getsentry/issue/JS-1245/pinotransport-ignores-msg-field
This sets up a basic E2E test for the Tanstack Start React SDK. For now I have added the following three tests: - An error thrown directly on the client is automatically captured. - An error thrown from a server side function is automatically captured. I am not sure why this works atm, but probably this is somehow propagated to the frontend. - An error thrown from a server route is only captured if we manually instrument it with `Sentry.captureException`. Closes #18265
This avoids looking up the integration for openai instrumentation, instead relying on this being passed in (which it already is). When manually instrumenting the client you need to pass in the options directly. 1. Node: Options are passed from the integration to instrumentOpenAiClient anyhow, so nothing changes 2. cloudflare/vercel-edge: There is no integration, users need to manually call instrumentOpenAiClient() and pass in the options anyhow (no integration to look anything up from exists there) See also #17694 Closes #18375 --------- Co-authored-by: RulaKhaled <rola.abuhasna@sentry.io>
Also, sort the fields in the integration test, in order to more easily se which fields were missing/misnamed in the fixture objects. Fix JS-1216 Fix JS-1236
Fixes JS-1223 Fixes GH-18331
This is the opposite of the flake that happened in #18035, so apparently nuxt-3 flaky tests started after merging that PR. It looks like the same problem, we have a race condition, if Nitro catches the error first when executing the middleware handler it will be swallowed by an H3 error but it seems the `instanceof` check isn't being satisfied in this case, so perhaps with Nuxt 3, there isn't a unified H3 instance or perhaps we are using a different one for the check. I will take a better look later, this is a band-aid to stop this from randomly failing our PRs. I couldn't reproduce this locally at all tho. If we don't like this relaxation we can close this PR and I can spend more time on this, I thought the most important thing here is we do capture an error with the critical information.
[Gitflow] Merge master into develop
Contributor
size-limit report 📦
|
chargome
approved these changes
Dec 4, 2025
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.