fix(google-cloud-serverless): Move @types/express to optional peerDeps #18452
+49
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(closes #18438)
(closes JS-1273)
This moves the express types as optional peerDependencies. Since we are only relying on
RequestandResponseand nothing more, this should be a save update. In order to also test against this - I updated the the local types to v5.The pattern of having the types as optional peerDependencies is already given for our Cloudflare SDK:
sentry-javascript/packages/cloudflare/package.json
Lines 55 to 62 in 2ef3938