chore: upgrade Playwright to ~1.56.0 for WSL2 compatibility #18468
+207
−184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
dev-packages/e2e-tests/test-applications/browser-webworker-vite/package.json
Outdated
Show resolved
Hide resolved
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
- Update userAgent to match Chromium 141 in playwright-config.ts - Filter out favicon resource spans in react-create-*-router tests - Add retry logic for flaky navigation in browser-integration-tests - Handle error status code navigation in astro-4/5 SSR error tests
Contributor
size-limit report 📦
|
Pages that return HTTP error status codes now fail with net::ERR_HTTP_RESPONSE_CODE_FAILURE in Playwright 1.56/Chromium 141
The value 'chromium' is not a valid Playwright channel option. Playwright uses the bundled Chromium by default when no channel is specified.
…ibility Playwright 1.56+ changed how glob patterns work in page.route(). The release notes recommend using regular expressions instead. This converts all 'https://dsn.ingest.sentry.io/**/*' glob patterns to regex equivalents: /^https:\/\/dsn\.ingest\.sentry\.io\//
Lms24
reviewed
Dec 11, 2025
...wser-integration-tests/suites/integrations/featureFlags/growthbook/onError/withScope/test.ts
Show resolved
Hide resolved
Comment on lines
+14
to
18
| // This page returns an error status code, so we need to catch the navigation error | ||
| await page.goto('/ssr-error').catch(() => { | ||
| // Expected to fail with net::ERR_HTTP_RESPONSE_CODE_FAILURE in newer Chromium versions | ||
| }); | ||
|
|
Member
There was a problem hiding this comment.
q: does playwright throw for requests with errors now?
Member
Author
There was a problem hiding this comment.
This is a Chromium behavior change in version 141 (bundled with Playwright 1.56). When navigating to a page that returns an HTTP error status code (4xx/5xx), Chromium now throws net::ERR_HTTP_RESPONSE_CODE_FAILURE.
This affects tests that intentionally navigate to error pages. The workaround is to catch the navigation error since we're testing the error handling behavior, not the navigation itself.
You can also use page.goto(url, { failOnStatusCode: false }) to suppress the error, but .catch() is more explicit about what's expected.
Member
There was a problem hiding this comment.
thanks for explaining. .catch sounds good to me then.
The retry logic was added as a workaround when glob patterns weren't matching. Now that we've converted to regex patterns, this is no longer needed. Surfacing flakes is better than masking them with retries.
# Conflicts: # dev-packages/test-utils/package.json
Lms24
approved these changes
Dec 11, 2025
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
Thanks for following up on my review. Good to merge from my end!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18469 (added automatically)