chore(e2e): Remove check on http.response_content_length_uncompressed
#18536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
dev-packages/e2e-tests/test-applications/node-express-esm-preload/tests/server.test.ts
Outdated
Show resolved
Hide resolved
timfish
changed the title
http.response_content_length_uncompressed
betegon
approved these changes
Dec 17, 2025
timfish
reviewed
Dec 17, 2025
| expect.objectContaining({ | ||
| span_id: expect.stringMatching(/[a-f0-9]{16}/), | ||
| trace_id: expect.stringMatching(/[a-f0-9]{32}/), | ||
| data: { |
Collaborator
There was a problem hiding this comment.
You need expect.objectContaining({ around data rather than the span.
…d` as its unreliable and flaky This comes strictly from OTel and we don't really need to assert on it.
andreiborza
force-pushed
the
ab/remove-response_content_length_uncompressed-attribute-checks
branch
from
6edd7fc to
3b3d366
Compare
timfish
approved these changes
Dec 17, 2025
andreiborza
deleted the
ab/remove-response_content_length_uncompressed-attribute-checks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comes strictly from OTel and we don't really need to assert on it, it's unreliable and flaky.
Closes #18537 (added automatically)