Skip to content

Conversation

@Lms24
Copy link
Member

@Lms24 Lms24 commented Dec 19, 2025

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).
  • Link an issue if there is one related to your pull request. If no issue is linked, one will be auto-generated and linked.

Closes #issue_link_here

andreiborza and others added 7 commits December 18, 2025 13:41
chore(ci): Skip build job when no code changes present
[Gitflow] Merge master into develop
If the error is caught with the hono error handler, no `trace` data was
sent alongside the event. This PR fixed this.

Before:
<img width="216" height="80" alt="image"
src="https://github.com/user-attachments/assets/35bc99b7-4a59-40e3-aad8-10130f816d68"
/>


After:
<img width="248" height="85" alt="image"
src="https://github.com/user-attachments/assets/dbc89577-0832-4166-8532-5210dc5e5d99"
/>
This removes a test that only asserted on successful deployment of a
static cloudflare app. No actual tests. I don't think there's much value
in this but it required a repo-specific env secret we can now get rid
of.

(fwiw, long-term we definitely want cloudflare-deployed e2e tests but
we'll likely need a better test setup anyway)

Closes #18568 (added automatically)
Explicitly enable `any` usage in typescript in:

- `dev-packages`, since those are largely integration and E2E tests.
  (This is done with the addition of a `dev-packages/.eslintrc.js`
  file.)
- `packages/*/test/`, since those are all tests. (This is done with a
  rule override added to the root `.eslintrc.js` file.)
- Several one-off allowances, generally for vendored types from third
  party sources, and cases involving function type extension/overriding
  that TypeScript can't follow. (These are done with file/line
  overrides, explicit `as` casting, and adding type inference to the
  `isInstanceOf` method.)

In other places (ie, in exported production code paths), replace `any`
with `unknown`, and upgrade the `@typescript/no-explicit-any` lint rule
to an error.

This silences a lot of eslint warnings that were habitually ignored, and
encourages us to not opt out of strict type safety in our exported code.
Makes sure that `gen_ai.input_tokens` value contains
`gen_ai.input_tokens.cached`
@Lms24 Lms24 changed the base branch from develop to master December 19, 2025 10:08
@Lms24 Lms24 requested review from a team as code owners December 19, 2025 10:08
Comment on lines +13 to 23
<details>
<summary> <strong>Internal Changes</strong> </summary>

- chore(lint): prefer 'unknown' to 'any', fix lint warnings
- chore(test): Remove `cloudflare-astro` e2e test ([#18567](https://github.com/getsentry/sentry-javascript/pull/18567))

</details>

## 10.32.0

### Important Changes

This comment was marked as outdated.

@andreiborza andreiborza changed the title meta: Update changelog for 10.32.1 meta(changelog): Update changelog for 10.32.1 Dec 19, 2025
@Lms24 Lms24 force-pushed the prepare-release/10.32.1 branch from a984f91 to a981a3d Compare December 19, 2025 10:15
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 24.82 kB added added
@sentry/browser - with treeshaking flags 23.32 kB added added
@sentry/browser (incl. Tracing) 41.59 kB added added
@sentry/browser (incl. Tracing, Profiling) 46.2 kB added added
@sentry/browser (incl. Tracing, Replay) 80.18 kB added added
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 69.91 kB added added
@sentry/browser (incl. Tracing, Replay with Canvas) 84.87 kB added added
@sentry/browser (incl. Tracing, Replay, Feedback) 97.1 kB added added
@sentry/browser (incl. Feedback) 41.54 kB added added
@sentry/browser (incl. sendFeedback) 29.51 kB added added
@sentry/browser (incl. FeedbackAsync) 34.5 kB added added
@sentry/react 26.54 kB added added
@sentry/react (incl. Tracing) 43.79 kB added added
@sentry/vue 29.29 kB added added
@sentry/vue (incl. Tracing) 43.41 kB added added
@sentry/svelte 24.84 kB added added
CDN Bundle 27.25 kB added added
CDN Bundle (incl. Tracing) 42.24 kB added added
CDN Bundle (incl. Tracing, Replay) 78.95 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback) 84.42 kB added added
CDN Bundle - uncompressed 80.06 kB added added
CDN Bundle (incl. Tracing) - uncompressed 125.41 kB added added
CDN Bundle (incl. Tracing, Replay) - uncompressed 241.94 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 254.71 kB added added
@sentry/nextjs (client) 46.01 kB added added
@sentry/sveltekit (client) 41.97 kB added added
@sentry/node-core 51.61 kB added added
@sentry/node 161.51 kB added added
@sentry/node - without tracing 93.05 kB added added
@sentry/aws-serverless 108.56 kB added added

@github-actions
Copy link
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 9,114 - - added
GET With Sentry 1,679 18% - added
GET With Sentry (error only) 6,054 66% - added
POST Baseline 1,192 - - added
POST With Sentry 580 49% - added
POST With Sentry (error only) 1,054 88% - added
MYSQL Baseline 3,239 - - added
MYSQL With Sentry 464 14% - added
MYSQL With Sentry (error only) 2,680 83% - added

@Lms24 Lms24 enabled auto-merge December 19, 2025 10:27
@Lms24 Lms24 merged commit 25f695d into master Dec 19, 2025
203 checks passed
@Lms24 Lms24 deleted the prepare-release/10.32.1 branch December 19, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants