Skip to content

Conversation

@MathurAditya724
Copy link
Member

@MathurAditya724 MathurAditya724 commented Jan 21, 2026

Closes #19076 (added automatically)

@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2026

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 8,841 - 8,725 +1%
GET With Sentry 1,683 19% 1,664 +1%
GET With Sentry (error only) 6,018 68% 6,107 -1%
POST Baseline 1,192 - 1,193 -0%
POST With Sentry 583 49% 597 -2%
POST With Sentry (error only) 1,054 88% 1,037 +2%
MYSQL Baseline 3,333 - 3,234 +3%
MYSQL With Sentry 431 13% 443 -3%
MYSQL With Sentry (error only) 2,697 81% 2,624 +3%

View base workflow run

@MathurAditya724 MathurAditya724 marked this pull request as ready for review January 29, 2026 09:07
@MathurAditya724 MathurAditya724 requested a review from Lms24 January 29, 2026 09:08
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. Happy to let you make the call on the naming discussion, so approving in advance :)

Comment on lines 432 to +436
if: cancelled() == false
continue-on-error: true
uses: codecov/test-results-action@v1
uses: getsentry/codecov-action@main
with:
files: packages/**/*.junit.xml
token: ${{ secrets.CODECOV_TOKEN }}
token: ${{ secrets.GITHUB_TOKEN }}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The workflow references a non-existent GitHub Action, getsentry/codecov-action@main, which will cause CI jobs for coverage and test reporting to fail.
Severity: HIGH

Suggested Fix

Replace the reference to the non-existent action getsentry/codecov-action@main with the correct, official action for uploading coverage reports, such as codecov/codecov-action. Ensure all required parameters like token are correctly configured for the official action.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: .github/workflows/build.yml#L432-L436

Potential issue: The CI workflow file `.github/workflows/build.yml` is updated to use a
new custom GitHub Action, `getsentry/codecov-action@main`, for uploading code coverage
reports. However, this action does not appear to exist in the specified repository or
any public location. When the workflow is triggered, GitHub Actions will fail to resolve
this action, causing an immediate failure of any job that attempts to use it. This will
prevent all code coverage and test result uploads from completing successfully, blocking
the CI/CD pipeline.

@MathurAditya724 MathurAditya724 merged commit 3cab272 into develop Jan 29, 2026
216 of 217 checks passed
@MathurAditya724 MathurAditya724 deleted the feat/codecov-new branch January 29, 2026 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: added support for the new codecov action

3 participants