-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat: added support for the new codecov action #18930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
Lms24
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM. Happy to let you make the call on the naming discussion, so approving in advance :)
| if: cancelled() == false | ||
| continue-on-error: true | ||
| uses: codecov/test-results-action@v1 | ||
| uses: getsentry/codecov-action@main | ||
| with: | ||
| files: packages/**/*.junit.xml | ||
| token: ${{ secrets.CODECOV_TOKEN }} | ||
| token: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: The workflow references a non-existent GitHub Action, getsentry/codecov-action@main, which will cause CI jobs for coverage and test reporting to fail.
Severity: HIGH
Suggested Fix
Replace the reference to the non-existent action getsentry/codecov-action@main with the correct, official action for uploading coverage reports, such as codecov/codecov-action. Ensure all required parameters like token are correctly configured for the official action.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: .github/workflows/build.yml#L432-L436
Potential issue: The CI workflow file `.github/workflows/build.yml` is updated to use a
new custom GitHub Action, `getsentry/codecov-action@main`, for uploading code coverage
reports. However, this action does not appear to exist in the specified repository or
any public location. When the workflow is triggered, GitHub Actions will fail to resolve
this action, causing an immediate failure of any job that attempts to use it. This will
prevent all code coverage and test result uploads from completing successfully, blocking
the CI/CD pipeline.
Closes #19076 (added automatically)