Skip to content

fix(tanstackstart-react): Use auto.middleware.tanstackstart as middleware trace origin #19137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicohrubec merged 2 commits into from
Feb 3, 2026
+12 −12
Merged

fix(tanstackstart-react): Use auto.middleware.tanstackstart as middleware trace origin #19137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e37cad2
fix(tanstackstart-react): Use auto.middleware.tanstackstart as middle…
nicohrubec Feb 3, 2026
9e34b09
Adjust size limit
nicohrubec Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .size-limit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ module.exports = [
import: createImport('init', 'ErrorBoundary', 'reactRouterV6BrowserTracingIntegration'),
ignore: ['react/jsx-runtime'],
gzip: true,
limit: '44.5 KB',
limit: '44.6 KB',
},
// Vue SDK (ESM)
{
Expand Down
18 changes: 9 additions & 9 deletions dev-packages/e2e-tests/test-applications/tanstackstart-react/tests/middleware.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,27 +22,27 @@ test('Sends spans for multiple middlewares and verifies they are siblings under
// Find both middleware spans
const serverFnMiddlewareSpan = transactionEvent?.spans?.find(
(span: { description?: string; origin?: string }) =>
span.description === 'serverFnMiddleware' && span.origin === 'manual.middleware.tanstackstart',
span.description === 'serverFnMiddleware' && span.origin === 'auto.middleware.tanstackstart',
);
const globalFunctionMiddlewareSpan = transactionEvent?.spans?.find(
(span: { description?: string; origin?: string }) =>
span.description === 'globalFunctionMiddleware' && span.origin === 'manual.middleware.tanstackstart',
span.description === 'globalFunctionMiddleware' && span.origin === 'auto.middleware.tanstackstart',
);

// Verify both middleware spans exist with expected properties
expect(serverFnMiddlewareSpan).toEqual(
expect.objectContaining({
description: 'serverFnMiddleware',
op: 'middleware.tanstackstart',
origin: 'manual.middleware.tanstackstart',
origin: 'auto.middleware.tanstackstart',
status: 'ok',
}),
);
expect(globalFunctionMiddlewareSpan).toEqual(
expect.objectContaining({
description: 'globalFunctionMiddleware',
op: 'middleware.tanstackstart',
origin: 'manual.middleware.tanstackstart',
origin: 'auto.middleware.tanstackstart',
status: 'ok',
}),
);
Expand Down Expand Up @@ -73,7 +73,7 @@ test('Sends spans for global function middleware', async ({ page }) => {
expect.objectContaining({
description: 'globalFunctionMiddleware',
op: 'middleware.tanstackstart',
origin: 'manual.middleware.tanstackstart',
origin: 'auto.middleware.tanstackstart',
status: 'ok',
}),
]),
Expand All @@ -100,7 +100,7 @@ test('Sends spans for global request middleware', async ({ page }) => {
expect.objectContaining({
description: 'globalRequestMiddleware',
op: 'middleware.tanstackstart',
origin: 'manual.middleware.tanstackstart',
origin: 'auto.middleware.tanstackstart',
status: 'ok',
}),
]),
Expand All @@ -127,7 +127,7 @@ test('Sends spans for server route request middleware', async ({ page }) => {
expect.objectContaining({
description: 'serverRouteRequestMiddleware',
op: 'middleware.tanstackstart',
origin: 'manual.middleware.tanstackstart',
origin: 'auto.middleware.tanstackstart',
status: 'ok',
}),
]),
Expand Down Expand Up @@ -156,7 +156,7 @@ test('Sends span for middleware that returns early without calling next()', asyn
expect.objectContaining({
description: 'earlyReturnMiddleware',
op: 'middleware.tanstackstart',
origin: 'manual.middleware.tanstackstart',
origin: 'auto.middleware.tanstackstart',
status: 'ok',
}),
]),
Expand Down Expand Up @@ -185,7 +185,7 @@ test('Sends span for middleware that throws an error', async ({ page }) => {
expect.objectContaining({
description: 'errorMiddleware',
op: 'middleware.tanstackstart',
origin: 'manual.middleware.tanstackstart',
origin: 'auto.middleware.tanstackstart',
}),
]),
);
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/e2e-tests/test-applications/tanstackstart-react/tests/transaction.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ test('Sends a server function transaction for a nested server function only if i
// Verify that globalFunctionMiddleware and testNestedLog are sibling spans under the root
const functionMiddlewareSpan = transactionEvent?.spans?.find(
(span: { description?: string; origin?: string }) =>
span.description === 'globalFunctionMiddleware' && span.origin === 'manual.middleware.tanstackstart',
span.description === 'globalFunctionMiddleware' && span.origin === 'auto.middleware.tanstackstart',
);
const nestedSpan = transactionEvent?.spans?.find(
(span: { description?: string; origin?: string }) =>
Expand Down
2 changes: 1 addition & 1 deletion packages/tanstackstart-react/src/server/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export function getMiddlewareSpanOptions(name: string): StartSpanOptions {
op: 'middleware.tanstackstart',
name,
attributes: {
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'manual.middleware.tanstackstart',
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.middleware.tanstackstart',
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'middleware.tanstackstart',
},
};
Expand Down
Loading