fix(core): Avoid blocking the process for weightBasedFlushing#19174
Merged
fix(core): Avoid blocking the process for weightBasedFlushing#19174
Conversation
RulaKhaled
approved these changes
Feb 5, 2026
Contributor
Codecov Results 📊Generated by Codecov Action |
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
nicohrubec
approved these changes
Feb 5, 2026
BYK
added a commit
to getsentry/cli
that referenced
this pull request
Feb 16, 2026
…es (#249) ## Summary Upgrade `@sentry/bun` and `@sentry/node` from 10.38.0 → 10.39.0 and remove all custom patches/workarounds that are now fixed upstream. ## Changes - **Removed `patches/@sentry%2Fcore@10.38.0.patch`** (92 lines) — Added `.unref()` to timers in `setupWeightBasedFlushing`, `_isClientDoneProcessing`, and `makePromiseBuffer` to prevent the CLI from hanging on exit. Fixed upstream by [#19062](getsentry/sentry-javascript#19062) and [#19174](getsentry/sentry-javascript#19174). - **Removed runtime context workaround in `src/lib/telemetry.ts`** (14 lines) — Manually overrode `options.runtime` after `Sentry.init()` to report Bun instead of Node.js. Fixed upstream — `NodeClient` now uses `options.runtime || { name: 'node', ... }` and `@sentry/bun` passes `{ name: 'bun', version: Bun.version }`. Tracked as [#19269](getsentry/sentry-javascript#19269). - **Updated `package.json`** — Bumped both SDK packages to `10.39.0` and removed `@sentry/core` from `patchedDependencies`. ## Verification - Verified all three upstream fixes by reading the 10.39.0 source code and linked PRs - `bun install`, typecheck, lint, and tests all pass cleanly - No new test failures introduced (pre-existing ~95 failures on `main` are unrelated)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #19171
closes JS-1641
This was is something that got missed by Copilot on #19062