Skip to content

fix(core): Remove outdated _experiments.enableMetrics references from metrics JSDoc#19252

Merged
chargome merged 1 commit intodevelopfrom
cg-metrics-jsdoc
Feb 10, 2026
Merged

fix(core): Remove outdated _experiments.enableMetrics references from metrics JSDoc#19252
chargome merged 1 commit intodevelopfrom
cg-metrics-jsdoc

Conversation

@chargome
Copy link
Member

@chargome chargome commented Feb 10, 2026

Metrics are enabled by default and no longer require the _experiments.enableMetrics flag. This removes the outdated JSDoc @summary references in count(), gauge(), and distribution() that still mentioned needing to enable the experimental option.

Closes #19253 (added automatically)

@chargome chargome self-assigned this Feb 10, 2026
@chargome chargome requested review from a team, logaretm and s1gr1d and removed request for a team February 10, 2026 15:08
@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2026

Codecov Results 📊


Generated by Codecov Action

@github-actions
Copy link
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 8,886 - 8,882 +0%
GET With Sentry 1,778 20% 1,756 +1%
GET With Sentry (error only) 6,067 68% 6,178 -2%
POST Baseline 1,173 - 1,182 -1%
POST With Sentry 587 50% 592 -1%
POST With Sentry (error only) 1,038 88% 1,038 -
MYSQL Baseline 3,364 - 3,315 +1%
MYSQL With Sentry 463 14% 446 +4%
MYSQL With Sentry (error only) 2,718 81% 2,680 +1%

View base workflow run

@chargome chargome enabled auto-merge (squash) February 10, 2026 16:06
@chargome chargome merged commit 140a6ed into develop Feb 10, 2026
429 of 432 checks passed
@chargome chargome deleted the cg-metrics-jsdoc branch February 10, 2026 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(core): Remove outdated _experiments.enableMetrics references from metrics JSDoc

2 participants