chore(e2e): Pin @embroider/macros to 1.19.7 in ember test apps#19515
Open
andreiborza wants to merge 1 commit intodevelopfrom
Open
chore(e2e): Pin @embroider/macros to 1.19.7 in ember test apps#19515andreiborza wants to merge 1 commit intodevelopfrom
andreiborza wants to merge 1 commit intodevelopfrom
Conversation
@embroider/macros 1.20.0 (released Feb 24) causes the Embroider+webpack build to produce different chunk output, breaking the dynamic import of @sentry/browser in the performance instrumentation. This results in no pageload/navigation transactions being created, failing all ember e2e tests.
JPeer264
approved these changes
Feb 25, 2026
Member
JPeer264
left a comment
JPeer264
left a comment
There was a problem hiding this comment.
If that works we should create a follow up ticket for investigation
Contributor
size-limit report 📦
|
chargome
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yesterday's
@embroider/macros1.20.0 release breaks our CI. Looks like the dynamic import of@sentry/browseris causing issues. Not really sure why yet tho but it leads to no pageload/navigation transactions in our e2e tests.Pinning to the previous version to unblock us for now.
Closes #19516 (added automatically)