Skip to content

ref(nestjs): Move event instrumentation unit tests to separate file#19738

Merged
nicohrubec merged 1 commit intodevelopfrom
nh/nestjs-event-tests-ref
Mar 10, 2026
Merged

ref(nestjs): Move event instrumentation unit tests to separate file#19738
nicohrubec merged 1 commit intodevelopfrom
nh/nestjs-event-tests-ref

Conversation

@nicohrubec
Copy link
Member

@nicohrubec nicohrubec commented Mar 10, 2026

No changes just moving the tests to a separate file to make it a bit more explicit what is what. Also updated the comment at the top of the event instrumentation to represent the updated behavior.

Closes #19740 (added automatically)

@github-actions
Copy link
Contributor

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 25.64 kB +0.05% +12 B 🔺
@sentry/browser - with treeshaking flags 24.14 kB +0.03% +7 B 🔺
@sentry/browser (incl. Tracing) 42.62 kB +0.45% +189 B 🔺
@sentry/browser (incl. Tracing, Profiling) 47.28 kB +0.41% +189 B 🔺
@sentry/browser (incl. Tracing, Replay) 81.43 kB +0.23% +184 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 71.01 kB +0.2% +141 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 86.14 kB +0.23% +192 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 98.39 kB +0.19% +185 B 🔺
@sentry/browser (incl. Feedback) 42.44 kB +0.02% +7 B 🔺
@sentry/browser (incl. sendFeedback) 30.31 kB +0.04% +11 B 🔺
@sentry/browser (incl. FeedbackAsync) 35.36 kB +0.04% +11 B 🔺
@sentry/browser (incl. Metrics) 26.8 kB +0.04% +9 B 🔺
@sentry/browser (incl. Logs) 26.95 kB +0.03% +8 B 🔺
@sentry/browser (incl. Metrics & Logs) 27.62 kB +0.04% +9 B 🔺
@sentry/react 27.39 kB +0.04% +9 B 🔺
@sentry/react (incl. Tracing) 44.95 kB +0.41% +183 B 🔺
@sentry/vue 30.09 kB +0.04% +10 B 🔺
@sentry/vue (incl. Tracing) 44.49 kB +0.42% +186 B 🔺
@sentry/svelte 25.66 kB +0.04% +9 B 🔺
CDN Bundle 28.18 kB +0.04% +9 B 🔺
CDN Bundle (incl. Tracing) 43.41 kB +0.36% +152 B 🔺
CDN Bundle (incl. Logs, Metrics) 29.02 kB +0.04% +9 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) 44.25 kB +0.33% +144 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) 68.1 kB +0.02% +8 B 🔺
CDN Bundle (incl. Tracing, Replay) 80.27 kB +0.17% +133 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 81.13 kB +0.16% +126 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 85.78 kB +0.16% +131 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 86.67 kB +0.16% +134 B 🔺
CDN Bundle - uncompressed 82.38 kB +0.04% +26 B 🔺
CDN Bundle (incl. Tracing) - uncompressed 128.36 kB +0.23% +288 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed 85.21 kB +0.04% +26 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 131.19 kB +0.23% +288 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 208.88 kB +0.02% +26 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 245.24 kB +0.12% +288 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 248.06 kB +0.12% +288 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 258.15 kB +0.12% +288 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 260.96 kB +0.12% +288 B 🔺
@sentry/nextjs (client) 47.37 kB +0.4% +187 B 🔺
@sentry/sveltekit (client) 43.07 kB +0.43% +181 B 🔺
@sentry/node-core 52.27 kB +0.07% +34 B 🔺
@sentry/node 174.77 kB +0.04% +62 B 🔺
@sentry/node - without tracing 97.44 kB +0.06% +52 B 🔺
@sentry/aws-serverless 113.24 kB +0.05% +49 B 🔺

View base workflow run

@nicohrubec nicohrubec merged commit da947ed into develop Mar 10, 2026
49 checks passed
@nicohrubec nicohrubec deleted the nh/nestjs-event-tests-ref branch March 10, 2026 15:16
andreiborza pushed a commit that referenced this pull request Mar 11, 2026
…19738)

No changes just moving the tests to a separate file to make it a bit
more explicit what is what. Also updated the comment at the top of the
event instrumentation to represent the updated behavior.

Closes #19740 (added automatically)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ref(nestjs): Move event instrumentation unit tests to separate file

2 participants