Skip to content

test(nextjs): Skip broken ISR tests #19871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chargome merged 2 commits into from
Mar 19, 2026
+24 −12
Merged

test(nextjs): Skip broken ISR tests #19871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c18ad73
test(nextjs-16-cf-workers): Skip ISR tests broken by opennext prefetc…
chargome Mar 19, 2026
661030d
test(nextjs-16-cf-workers): Skip remaining failing tests on latest va…
chargome Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...ackages/e2e-tests/test-applications/nextjs-16-cf-workers/tests/cloudflare-runtime.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import { expect, test } from '@playwright/test';
import { waitForError } from '@sentry-internal/test-utils';

test.describe('Cloudflare Runtime', () => {
// TODO(https://github.com/opennextjs/opennextjs-cloudflare/issues/1141): Unskip once opennext supports prefetch-hints.json
test.describe.skip('Cloudflare Runtime', () => {
test('Should report cloudflare as the runtime in API route error events', async ({ request }) => {
const errorEventPromise = waitForError('nextjs-16-cf-workers', errorEvent => {
return !!errorEvent?.exception?.values?.some(value =>
Expand Down
15 changes: 10 additions & 5 deletions dev-packages/e2e-tests/test-applications/nextjs-16-cf-workers/tests/isr-routes.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';

test('should remove sentry-trace and baggage meta tags on ISR dynamic route page load', async ({ page }) => {
// TODO(https://github.com/opennextjs/opennextjs-cloudflare/issues/1141): Unskip once opennext supports prefetch-hints.json
test.skip('should remove sentry-trace and baggage meta tags on ISR dynamic route page load', async ({ page }) => {
// Navigate to ISR page
await page.goto('/isr-test/laptop');

Expand All @@ -13,7 +14,8 @@ test('should remove sentry-trace and baggage meta tags on ISR dynamic route page
await expect(page.locator('meta[name="baggage"]')).toHaveCount(0);
});

test('should remove sentry-trace and baggage meta tags on ISR static route', async ({ page }) => {
// TODO(https://github.com/opennextjs/opennextjs-cloudflare/issues/1141): Unskip once opennext supports prefetch-hints.json
test.skip('should remove sentry-trace and baggage meta tags on ISR static route', async ({ page }) => {
// Navigate to ISR static page
await page.goto('/isr-test/static');

Expand All @@ -25,7 +27,8 @@ test('should remove sentry-trace and baggage meta tags on ISR static route', asy
await expect(page.locator('meta[name="baggage"]')).toHaveCount(0);
});

test('should remove meta tags for different ISR dynamic route values', async ({ page }) => {
// TODO(https://github.com/opennextjs/opennextjs-cloudflare/issues/1141): Unskip once opennext supports prefetch-hints.json
test.skip('should remove meta tags for different ISR dynamic route values', async ({ page }) => {
// Test with 'phone' (one of the pre-generated static params)
await page.goto('/isr-test/phone');
await expect(page.locator('#isr-product-id')).toHaveText('phone');
Expand All @@ -41,7 +44,8 @@ test('should remove meta tags for different ISR dynamic route values', async ({
await expect(page.locator('meta[name="baggage"]')).toHaveCount(0);
});

test('should create unique transactions for ISR pages on each visit', async ({ page }) => {
// TODO(https://github.com/opennextjs/opennextjs-cloudflare/issues/1141): Unskip once opennext supports prefetch-hints.json
test.skip('should create unique transactions for ISR pages on each visit', async ({ page }) => {
const traceIds: string[] = [];

// Load the same ISR page 5 times to ensure cached HTML meta tags are consistently removed
Expand Down Expand Up @@ -71,7 +75,8 @@ test('should create unique transactions for ISR pages on each visit', async ({ p
expect(uniqueTraceIds.size).toBe(5);
});

test('ISR route should be identified correctly in the route manifest', async ({ page }) => {
// TODO(https://github.com/opennextjs/opennextjs-cloudflare/issues/1141): Unskip once opennext supports prefetch-hints.json
test.skip('ISR route should be identified correctly in the route manifest', async ({ page }) => {
const transactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent.transaction === '/isr-test/:product' && transactionEvent.contexts?.trace?.op === 'pageload';
});
Expand Down
12 changes: 8 additions & 4 deletions ...kages/e2e-tests/test-applications/nextjs-16-cf-workers/tests/parameterized-routes.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';

test('should create a parameterized transaction when the `app` directory is used', async ({ page }) => {
// TODO(https://github.com/opennextjs/opennextjs-cloudflare/issues/1141): Unskip once opennext supports prefetch-hints.json
test.skip('should create a parameterized transaction when the `app` directory is used', async ({ page }) => {
const transactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return (
transactionEvent.transaction === '/parameterized/:one' && transactionEvent.contexts?.trace?.op === 'pageload'
Expand Down Expand Up @@ -47,7 +48,8 @@ test('should create a parameterized transaction when the `app` directory is used
});
});

test('should create a static transaction when the `app` directory is used and the route is not parameterized', async ({
// TODO(https://github.com/opennextjs/opennextjs-cloudflare/issues/1141): Unskip once opennext supports prefetch-hints.json
test.skip('should create a static transaction when the `app` directory is used and the route is not parameterized', async ({
page,
}) => {
const transactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
Expand Down Expand Up @@ -95,7 +97,8 @@ test('should create a static transaction when the `app` directory is used and th
});
});

test('should create a partially parameterized transaction when the `app` directory is used', async ({ page }) => {
// TODO(https://github.com/opennextjs/opennextjs-cloudflare/issues/1141): Unskip once opennext supports prefetch-hints.json
test.skip('should create a partially parameterized transaction when the `app` directory is used', async ({ page }) => {
const transactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return (
transactionEvent.transaction === '/parameterized/:one/beep' && transactionEvent.contexts?.trace?.op === 'pageload'
Expand Down Expand Up @@ -141,7 +144,8 @@ test('should create a partially parameterized transaction when the `app` directo
});
});

test('should create a nested parameterized transaction when the `app` directory is used.', async ({ page }) => {
// TODO(https://github.com/opennextjs/opennextjs-cloudflare/issues/1141): Unskip once opennext supports prefetch-hints.json
test.skip('should create a nested parameterized transaction when the `app` directory is used.', async ({ page }) => {
const transactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return (
transactionEvent.transaction === '/parameterized/:one/beep/:two' &&
Expand Down
3 changes: 2 additions & 1 deletion dev-packages/e2e-tests/test-applications/nextjs-16-cf-workers/tests/prefetch-spans.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';
import { isDevMode } from './isDevMode';

test('Prefetch client spans should have a http.request.prefetch attribute', async ({ page }) => {
// TODO(https://github.com/opennextjs/opennextjs-cloudflare/issues/1141): Unskip once opennext supports prefetch-hints.json
test.skip('Prefetch client spans should have a http.request.prefetch attribute', async ({ page }) => {
test.skip(isDevMode, "Prefetch requests don't have the prefetch header in dev mode");

const pageloadTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
Expand Down
3 changes: 2 additions & 1 deletion ...ckages/e2e-tests/test-applications/nextjs-16-cf-workers/tests/streaming-rsc-error.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import { expect, test } from '@playwright/test';
import { waitForError, waitForTransaction } from '@sentry-internal/test-utils';

test('Should capture errors for crashing streaming promises in server components when `Sentry.captureRequestError` is added to the `onRequestError` hook', async ({
// TODO(https://github.com/opennextjs/opennextjs-cloudflare/issues/1141): Unskip once opennext supports prefetch-hints.json
test.skip('Should capture errors for crashing streaming promises in server components when `Sentry.captureRequestError` is added to the `onRequestError` hook', async ({
page,
}) => {
const errorEventPromise = waitForError('nextjs-16-cf-workers', errorEvent => {
Expand Down
Loading