chore: Add size limit reports on PRs for Cloudflare#20055
Conversation
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Core
Deps
Other
Bug Fixes 🐛
Internal Changes 🔧Core
Deps
Other
🤖 This preview updates automatically when you update the PR. |
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
fada93f to
a10aeaf
Compare
size-limit report 📦
|
25e1358 to
ff50c70
Compare
Lms24
left a comment
There was a problem hiding this comment.
looks like some other commits made it to this branch 🤔 😅
also, no objections to adding a size limit entry! Just to check: when you add the SDK to cloudflare workers (or other components): Does this roughly equate to the same size? Just wondering if we're missing any dependencies/node_modules data that might make the SDK's footprint larger in reality than the size check shows
|
Ok the auto rebase function from GitHub doesn't work as expected :D
There is indeed something missing. I'll try to add it |
ff50c70 to
8b4317d
Compare
|
Converting to draft, as for Cloudflare we have to use I opened an issue to see if it would be possible to have two bundlers in one size-limit file |
dd738e9 to
aa20299
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 72e3bd6. Configure here.
72e3bd6 to
aaa4845
Compare

Cloudflare does have a free tier limit of 3mb: https://developers.cloudflare.com/workers/platform/limits/#worker-size
It would be too bad if we ship something for Cloudflare and by accident ship something which is super costly.
wranglerbundles inesbuild, so we have to add theesbuildplugin, but we need to disableesbuildfor other builds to keep bundle the rest inwebpack. Which is why I disabledesbuildeverywhere, except for Cloudflare.size-limitdefaults to esbuild if enabled