fix(core): Only attach flags context to error events#20116
Merged
Conversation
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Core
Deps
Other
Bug Fixes 🐛Core
Other
Internal Changes 🔧Core
Deps
Other
🤖 This preview updates automatically when you update the PR. |
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
Lms24
requested review from
a team,
logaretm and
s1gr1d
and removed request for
a team
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Error event test doesn't verify flags were copied
- Added proper assertion to verify event.contexts.flags contains the expected flags instead of just checking reference equality.
Or push these changes by commenting:
@cursor push 223cf450c5
Preview (223cf450c5)
diff --git a/packages/core/test/lib/utils/featureFlags.test.ts b/packages/core/test/lib/utils/featureFlags.test.ts
--- a/packages/core/test/lib/utils/featureFlags.test.ts
+++ b/packages/core/test/lib/utils/featureFlags.test.ts
@@ -164,8 +164,13 @@
const result = _INTERNAL_copyFlagsFromScopeToEvent(event);
- expect(result).toEqual(event);
expect(getCurrentScope).toHaveBeenCalled();
+ expect(result.contexts?.flags).toEqual({
+ values: [
+ { flag: 'feat1', result: true },
+ { flag: 'feat2', result: false },
+ ],
+ });
});
});
});This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 53e6de3. Configure here.
mydea
approved these changes
Apr 8, 2026
logaretm
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While looking into feature flags for span streaming, we noticed that the SDK currently attaches the
flagscontext to all outgoing event types, including transactions (h/t @mjq). The develop spec specifies that feature flags should be added toflagscontextThis PR ensures that the event processor adding the context is scoped to error events only.