Skip to content

chore(ci): Remove codecov steps from jobs that produce no coverage/JUnit data #20244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mydea merged 2 commits into from
Apr 13, 2026
+2 −37
Merged

chore(ci): Remove codecov steps from jobs that produce no coverage/JUnit data #20244

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9788030
chore(ci): Skip coverage check for playwright browser tests
mydea Apr 13, 2026
472526a
fix(ci): Remove codecov steps from jobs that produce no coverage/JUni…
mydea Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 2 additions & 37 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,6 +605,7 @@ jobs:
with:
token: ${{ secrets.GITHUB_TOKEN }}
directory: dev-packages/browser-integration-tests
enable-coverage: false
name:
browser-playwright-${{ matrix.bundle }}-${{ matrix.project }}${{ matrix.shard && format('-{0}',
matrix.shard) || '' }}
Expand Down Expand Up @@ -669,6 +670,7 @@ jobs:
with:
token: ${{ secrets.GITHUB_TOKEN }}
directory: dev-packages/browser-integration-tests
enable-coverage: false
name: browser-loader-${{ matrix.bundle }}

job_check_for_faulty_dts:
Expand Down Expand Up @@ -737,15 +739,6 @@ jobs:
working-directory: dev-packages/node-integration-tests
run: yarn test

- name: Parse and Upload Coverage
if: cancelled() == false
continue-on-error: true
uses: getsentry/codecov-action@main
with:
token: ${{ secrets.GITHUB_TOKEN }}
directory: dev-packages/node-integration-tests
name: node-integration-${{ matrix.node }}${{ matrix.typescript && format('-ts{0}', matrix.typescript) || '' }}

job_node_core_integration_tests:
name:
Node (${{ matrix.node }})${{ (matrix.typescript && format(' (TS {0})', matrix.typescript)) || '' }} Node-Core
Expand Down Expand Up @@ -787,16 +780,6 @@ jobs:
working-directory: dev-packages/node-core-integration-tests
run: yarn test

- name: Parse and Upload Coverage
if: cancelled() == false
continue-on-error: true
uses: getsentry/codecov-action@main
with:
token: ${{ secrets.GITHUB_TOKEN }}
directory: dev-packages/node-core-integration-tests
name:
node-core-integration-${{ matrix.node }}${{ matrix.typescript && format('-ts{0}', matrix.typescript) || ''}}

job_cloudflare_integration_tests:
name: Cloudflare Integration Tests
needs: [job_get_metadata, job_build]
Expand Down Expand Up @@ -856,15 +839,6 @@ jobs:
cd packages/remix
yarn test:integration:ci

- name: Parse and Upload Coverage
if: cancelled() == false
continue-on-error: true
uses: getsentry/codecov-action@main
with:
directory: packages/remix
token: ${{ secrets.GITHUB_TOKEN }}
name: ${{ matrix.node }}

job_e2e_prepare:
name: Prepare E2E tests
# We want to run this if:
Expand Down Expand Up @@ -1053,15 +1027,6 @@ jobs:
retention-days: 7
if-no-files-found: ignore

- name: Parse and Upload Coverage
if: cancelled() == false
continue-on-error: true
uses: getsentry/codecov-action@main
with:
directory: dev-packages/e2e-tests
token: ${{ secrets.GITHUB_TOKEN }}
name: e2e-${{ matrix.test-application }}

# - We skip optional tests on release branches
job_optional_e2e_tests:
name: E2E ${{ matrix.label || matrix.test-application }} Test (optional)
Expand Down
Loading