ci: Remove Docker container for Verdaccio package publishing

.github/workflows/build.yml

@@ -959,20 +959,13 @@ jobs:
         if: steps.restore-tarball-cache.outputs.cache-hit != 'true'
         run: yarn build:tarball
 
-      - name: Get node version
-        id: versions
-        run: |
-          echo "echo node=$(jq -r '.volta.node' dev-packages/e2e-tests/package.json)" >> $GITHUB_OUTPUT
-
       - name: Validate Verdaccio
         run: yarn test:validate
         working-directory: dev-packages/e2e-tests
 
       - name: Prepare Verdaccio
         run: yarn test:prepare
         working-directory: dev-packages/e2e-tests
-        env:
-          E2E_TEST_PUBLISH_SCRIPT_NODE_VERSION: ${{ steps.versions.outputs.node }}
 
       - name: Copy to temp
         run: yarn ci:copy-to-temp ./test-applications/${{ matrix.test-application }} ${{ runner.temp }}/test-application
@@ -1076,20 +1069,13 @@ jobs:
         if: steps.restore-tarball-cache.outputs.cache-hit != 'true'
         run: yarn build:tarball
 
-      - name: Get node version
-        id: versions
-        run: |
-          echo "echo node=$(jq -r '.volta.node' dev-packages/e2e-tests/package.json)" >> $GITHUB_OUTPUT
-
       - name: Validate Verdaccio
         run: yarn test:validate
         working-directory: dev-packages/e2e-tests
 
       - name: Prepare Verdaccio
         run: yarn test:prepare
         working-directory: dev-packages/e2e-tests
-        env:
-          E2E_TEST_PUBLISH_SCRIPT_NODE_VERSION: ${{ steps.versions.outputs.node }}
 
       - name: Copy to temp
         run: yarn ci:copy-to-temp ./test-applications/${{ matrix.test-application }} ${{ runner.temp }}/test-application

.github/workflows/canary.yml

@@ -140,20 +140,13 @@ jobs:
           path: ${{ env.CACHED_BUILD_PATHS }}
           key: canary-${{ env.HEAD_COMMIT }}
 
-      - name: Get node version
-        id: versions
-        run: |
-          echo "echo node=$(jq -r '.volta.node' dev-packages/e2e-tests/package.json)" >> $GITHUB_OUTPUT
-
       - name: Validate Verdaccio
         run: yarn test:validate
         working-directory: dev-packages/e2e-tests
 
       - name: Prepare Verdaccio
         run: yarn test:prepare
         working-directory: dev-packages/e2e-tests
-        env:
-          E2E_TEST_PUBLISH_SCRIPT_NODE_VERSION: ${{ steps.versions.outputs.node }}
 
       - name: Copy to temp
         run: yarn ci:copy-to-temp ./test-applications/${{ matrix.test-application }} ${{ runner.temp }}/test-application

dev-packages/e2e-tests/lib/constants.ts

@@ -2,4 +2,3 @@ export const TEST_REGISTRY_CONTAINER_NAME = 'verdaccio-e2e-test-registry';
 export const DEFAULT_BUILD_TIMEOUT_SECONDS = 60 * 5;
 export const DEFAULT_TEST_TIMEOUT_SECONDS = 60 * 2;
 export const VERDACCIO_VERSION = '5.22.1';
-export const PUBLISH_PACKAGES_DOCKER_IMAGE_NAME = 'publish-packages';

dev-packages/e2e-tests/lib/publishPackages.ts

@@ -0,0 +1,41 @@
+/* eslint-disable no-console */
+import * as childProcess from 'child_process';
+import { readFileSync } from 'fs';
+import { globSync } from 'glob';
+import * as path from 'path';
+
+const repositoryRoot = path.resolve(__dirname, '../../..');
+
+/**
+ * Publishes all built Sentry package tarballs to the local Verdaccio test registry.
+ */
+export function publishPackages(): void {
+  const version = (JSON.parse(readFileSync(path.join(__dirname, '../package.json'), 'utf8')) as { version: string })
+    .version;
+
+  // Get absolute paths of all the packages we want to publish to the fake registry
+  // Only include the current versions, to avoid getting old tarballs published as well
+  const packageTarballPaths = globSync(`packages/*/sentry-*-${version}.tgz`, {
+    cwd: repositoryRoot,
+    absolute: true,
+  });
+
+  if (packageTarballPaths.length === 0) {
+    throw new Error(`No packages to publish for version ${version}, did you run "yarn build:tarballs"?`);
+  }
+
+  const npmrc = path.join(__dirname, '../test-registry.npmrc');
+
+  for (const tarballPath of packageTarballPaths) {
+    console.log(`Publishing tarball ${tarballPath} ...`);
+    const result = childProcess.spawnSync('npm', ['--userconfig', npmrc, 'publish', tarballPath], {
+      cwd: repositoryRoot,
+      encoding: 'utf8',
+      stdio: 'inherit',
+    });
+
+    if (result.status !== 0) {
+      throw new Error(`Error publishing tarball ${tarballPath}`);
+    }
+  }
+}

dev-packages/e2e-tests/registrySetup.ts

@@ -1,10 +1,7 @@
 /* eslint-disable no-console */
 import * as childProcess from 'child_process';
-import * as path from 'path';
-import { PUBLISH_PACKAGES_DOCKER_IMAGE_NAME, TEST_REGISTRY_CONTAINER_NAME, VERDACCIO_VERSION } from './lib/constants';
-
-const publishScriptNodeVersion = process.env.E2E_TEST_PUBLISH_SCRIPT_NODE_VERSION;
-const repositoryRoot = path.resolve(__dirname, '../..');
+import { TEST_REGISTRY_CONTAINER_NAME, VERDACCIO_VERSION } from './lib/constants';
+import { publishPackages } from './lib/publishPackages';
 
 // https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#grouping-log-lines
 function groupCIOutput(groupTitle: string, fn: () => void): void {
@@ -45,56 +42,7 @@ export function registrySetup(): void {
       throw new Error('Start Registry Process failed.');
     }
 
-    // Build container image that is uploading our packages to fake registry with specific Node.js/npm version
-    const buildPublishImageProcessResult = childProcess.spawnSync(
-      'docker',
-      [
-        'build',
-        '--tag',
-        PUBLISH_PACKAGES_DOCKER_IMAGE_NAME,
-        '--file',
-        './Dockerfile.publish-packages',
-        ...(publishScriptNodeVersion ? ['--build-arg', `NODE_VERSION=${publishScriptNodeVersion}`] : []),
-        '.',
-      ],
-      {
-        encoding: 'utf8',
-        stdio: 'inherit',
-      },
-    );
-
-    if (buildPublishImageProcessResult.status !== 0) {
-      throw new Error('Build Publish Image failed.');
-    }
-
-    // Run container that uploads our packages to fake registry
-    const publishImageContainerRunProcess = childProcess.spawnSync(
-      'docker',
-      [
-        'run',
-        '--rm',
-        '-v',
-        `${repositoryRoot}:/sentry-javascript`,
-        '--network',
-        'host',
-        PUBLISH_PACKAGES_DOCKER_IMAGE_NAME,
-      ],
-      {
-        encoding: 'utf8',
-        stdio: 'inherit',
-      },
-    );
-
-    const statusCode = publishImageContainerRunProcess.status;
-
-    if (statusCode !== 0) {
-      if (statusCode === 137) {
-        throw new Error(
-          `Publish Image Container failed with exit code ${statusCode}, possibly due to memory issues. Consider increasing the memory limit for the container.`,
-        );
-      }
-      throw new Error(`Publish Image Container failed with exit code ${statusCode}`);
-    }
+    publishPackages();
   });
 
   console.log('');