Skip to content

feat(browser): Add support for streamed spans in cultureContextIntegration#20352

Open
Lms24 wants to merge 4 commits intodevelopfrom
lms/feat-browser-culture-context-streamed
Open

feat(browser): Add support for streamed spans in cultureContextIntegration#20352
Lms24 wants to merge 4 commits intodevelopfrom
lms/feat-browser-culture-context-streamed

Conversation

@Lms24
Copy link
Copy Markdown
Member

@Lms24 Lms24 commented Apr 16, 2026

This PR adds span processing support for the cultureContextIntegration plus a few integration API additions to make span processing on an integration level easier:

  • Integration::processSegmentSpan
  • Integration::processSpan
  • register a processSegmentSpan callback on cultureContextIntegration that adds the attributes. All attributes are already registered in sentry conventions: https://getsentry.github.io/sentry-conventions/attributes/culture/
  • adds a span streaming-specific integration test in addition to the already existing error/event-based integration test

closes #20353
closes #20354

@Lms24 Lms24 self-assigned this Apr 16, 2026
@Lms24 Lms24 marked this pull request as ready for review April 16, 2026 13:54
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d6dedf6. Configure here.

Comment thread packages/browser/src/integrations/culturecontext.ts Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 16, 2026

size-limit report 📦

Path Size % Change Change
@sentry/browser 25.87 kB +0.35% +88 B 🔺
@sentry/browser - with treeshaking flags 24.36 kB +0.34% +82 B 🔺
@sentry/browser (incl. Tracing) 43.72 kB +0.26% +112 B 🔺
@sentry/browser (incl. Tracing + Span Streaming) 45.42 kB +0.23% +104 B 🔺
@sentry/browser (incl. Tracing, Profiling) 48.64 kB +0.27% +127 B 🔺
@sentry/browser (incl. Tracing, Replay) 82.83 kB +0.12% +94 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 72.34 kB +0.13% +93 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 87.52 kB +0.11% +96 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 99.78 kB +0.11% +108 B 🔺
@sentry/browser (incl. Feedback) 42.7 kB +0.26% +107 B 🔺
@sentry/browser (incl. sendFeedback) 30.54 kB +0.28% +85 B 🔺
@sentry/browser (incl. FeedbackAsync) 35.55 kB +0.27% +94 B 🔺
@sentry/browser (incl. Metrics) 27.16 kB +0.34% +90 B 🔺
@sentry/browser (incl. Logs) 27.29 kB +0.33% +89 B 🔺
@sentry/browser (incl. Metrics & Logs) 27.98 kB +0.31% +86 B 🔺
@sentry/react 27.62 kB +0.33% +90 B 🔺
@sentry/react (incl. Tracing) 45.97 kB +0.18% +81 B 🔺
@sentry/vue 30.7 kB +0.28% +85 B 🔺
@sentry/vue (incl. Tracing) 45.54 kB +0.19% +86 B 🔺
@sentry/svelte 25.89 kB +0.33% +85 B 🔺
CDN Bundle 28.56 kB +0.36% +100 B 🔺
CDN Bundle (incl. Tracing) 44.8 kB +0.24% +105 B 🔺
CDN Bundle (incl. Logs, Metrics) 29.93 kB +0.33% +96 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) 45.88 kB +0.23% +103 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) 68.83 kB +0.14% +94 B 🔺
CDN Bundle (incl. Tracing, Replay) 81.74 kB +0.11% +88 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 82.81 kB +0.11% +86 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 87.27 kB +0.12% +97 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 88.33 kB +0.12% +98 B 🔺
CDN Bundle - uncompressed 83.51 kB +0.47% +384 B 🔺
CDN Bundle (incl. Tracing) - uncompressed 134.02 kB +0.29% +384 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed 87.65 kB +0.45% +384 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 137.43 kB +0.29% +384 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 211.02 kB +0.19% +384 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 251.25 kB +0.16% +384 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 254.65 kB +0.16% +384 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 264.17 kB +0.15% +384 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 267.55 kB +0.15% +384 B 🔺
@sentry/nextjs (client) 48.5 kB +0.17% +80 B 🔺
@sentry/sveltekit (client) 44.14 kB +0.2% +85 B 🔺
@sentry/node-core 57.97 kB +0.07% +39 B 🔺
@sentry/node 174.82 kB +0.03% +45 B 🔺
@sentry/node - without tracing 97.92 kB +0.06% +52 B 🔺
@sentry/aws-serverless 115.16 kB +0.04% +44 B 🔺

View base workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support span streaming in cultureContextIntegration Add integration hooks to process (segment) spans

1 participant