feat(nextjs): Filter unwanted segments when span streaming is enabled#20384
Draft
feat(nextjs): Filter unwanted segments when span streaming is enabled#20384
Conversation
Lms24
changed the title
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #20374
This is a pretty neat case where I think we can even get rid of the event processors entirely and just rely on
ignoreSpansfor transactions and streamed spans. Let's see if CI agrees.Needs tests to check the span streaming code path! Please feel free to pick this up or close with another PR doing it differently :)