fix(core): Correct GoogleGenAIIstrumentedMethod typo in type name#20416
Merged
fix(core): Correct GoogleGenAIIstrumentedMethod typo in type name#20416
Conversation
Contributor
size-limit report 📦
|
chargome
reviewed
Apr 21, 2026
Member
chargome
left a comment
There was a problem hiding this comment.
Nice find! Please just remove the changelog entry and we're good.
Member
There was a problem hiding this comment.
@alwx We can remove this entry, this will be generated automatically
Rename `GoogleGenAIIstrumentedMethod` to `GoogleGenAIInstrumentedMethod` (previously missing an 'n'). The misspelled name is kept as a deprecated type alias and is still re-exported from `@sentry/core`, so existing consumers continue to work without changes. The deprecated alias will be removed in the next major version.
fde6491 to
fe4428e
Compare
chargome
approved these changes
Apr 21, 2026
JPeer264
approved these changes
Apr 21, 2026
Member
JPeer264
left a comment
There was a problem hiding this comment.
Amazing catch. Thx for fixing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a typo in the type exported from
@sentry/corefor Google Gen AI instrumentation:GoogleGenAIIstrumentedMethod(missing ann) ->GoogleGenAIInstrumentedMethod.The misspelled name is preserved as a deprecated type alias that points at the correctly-spelled type, so existing code keeps working:
Noticed while wiring up the re-exports of the AI SDK manual instrumentation helpers from
@sentry/react-native(getsentry/sentry-react-native#6028). The typo was blocking a clean re-export.Checklist
google-genaitests still pass. No runtime behaviour changes; this is a type-only rename with a backwards-compat alias.yarn test google-genai→ 5/5 passing. Type emit forpackages/coreverified: bothGoogleGenAIInstrumentedMethodandGoogleGenAIIstrumentedMethodappear inbuild/types/index.d.ts.#skip-changelog