Skip to content

fix(core): Correct GoogleGenAIIstrumentedMethod typo in type name#20416

Merged
alwx merged 1 commit intodevelopfrom
fix/google-genai-instrumented-method-typo
Apr 21, 2026
Merged

fix(core): Correct GoogleGenAIIstrumentedMethod typo in type name#20416
alwx merged 1 commit intodevelopfrom
fix/google-genai-instrumented-method-typo

Conversation

@alwx
Copy link
Copy Markdown
Contributor

@alwx alwx commented Apr 21, 2026

Description

Fixes a typo in the type exported from @sentry/core for Google Gen AI instrumentation: GoogleGenAIIstrumentedMethod (missing an n) -> GoogleGenAIInstrumentedMethod.

The misspelled name is preserved as a deprecated type alias that points at the correctly-spelled type, so existing code keeps working:

import type { GoogleGenAIInstrumentedMethod } from '@sentry/core';

/**
 * @deprecated Use {@link GoogleGenAIInstrumentedMethod} instead.
 */
export type GoogleGenAIIstrumentedMethod = GoogleGenAIInstrumentedMethod;

Noticed while wiring up the re-exports of the AI SDK manual instrumentation helpers from @sentry/react-native (getsentry/sentry-react-native#6028). The typo was blocking a clean re-export.

Checklist

  • Added tests where applicable — existing google-genai tests still pass. No runtime behaviour changes; this is a type-only rename with a backwards-compat alias.
  • Code lints and the test suite passes — yarn test google-genai → 5/5 passing. Type emit for packages/core verified: both GoogleGenAIInstrumentedMethod and GoogleGenAIIstrumentedMethod appear in build/types/index.d.ts.
  • No open issue — this is a follow-up to review feedback on feat(ai): Re-export AI SDK manual instrumentation helpers sentry-react-native#6028.

#skip-changelog

@alwx alwx marked this pull request as ready for review April 21, 2026 11:07
@alwx alwx requested review from a team, JPeer264 and chargome and removed request for a team April 21, 2026 11:08
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 21, 2026

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 25.88 kB - -
@sentry/browser - with treeshaking flags 24.35 kB - -
@sentry/browser (incl. Tracing) 43.81 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 45.5 kB - -
@sentry/browser (incl. Tracing, Profiling) 48.73 kB - -
@sentry/browser (incl. Tracing, Replay) 82.98 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 72.5 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 87.67 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 99.93 kB - -
@sentry/browser (incl. Feedback) 42.7 kB - -
@sentry/browser (incl. sendFeedback) 30.55 kB - -
@sentry/browser (incl. FeedbackAsync) 35.55 kB - -
@sentry/browser (incl. Metrics) 27.16 kB - -
@sentry/browser (incl. Logs) 27.29 kB - -
@sentry/browser (incl. Metrics & Logs) 27.98 kB - -
@sentry/react 27.62 kB - -
@sentry/react (incl. Tracing) 46.05 kB - -
@sentry/vue 30.71 kB - -
@sentry/vue (incl. Tracing) 45.62 kB - -
@sentry/svelte 25.89 kB - -
CDN Bundle 28.55 kB - -
CDN Bundle (incl. Tracing) 44.94 kB - -
CDN Bundle (incl. Logs, Metrics) 29.93 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 46.03 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 68.89 kB - -
CDN Bundle (incl. Tracing, Replay) 81.96 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 83.03 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 87.46 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 88.55 kB - -
CDN Bundle - uncompressed 83.4 kB - -
CDN Bundle (incl. Tracing) - uncompressed 134.3 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 87.55 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 137.72 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 211.12 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 251.75 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 255.14 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 264.66 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 268.05 kB - -
@sentry/nextjs (client) 48.58 kB - -
@sentry/sveltekit (client) 44.22 kB - -
@sentry/node-core 58.02 kB +0.02% +7 B 🔺
@sentry/node 174.89 kB +0.01% +6 B 🔺
@sentry/node - without tracing 97.98 kB +0.02% +12 B 🔺
@sentry/aws-serverless 115.21 kB +0.02% +17 B 🔺

View base workflow run

Copy link
Copy Markdown
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! Please just remove the changelog entry and we're good.

Comment thread CHANGELOG.md
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alwx We can remove this entry, this will be generated automatically

@chargome chargome self-assigned this Apr 21, 2026
Rename `GoogleGenAIIstrumentedMethod` to `GoogleGenAIInstrumentedMethod`
(previously missing an 'n'). The misspelled name is kept as a deprecated
type alias and is still re-exported from `@sentry/core`, so existing
consumers continue to work without changes.

The deprecated alias will be removed in the next major version.
@alwx alwx force-pushed the fix/google-genai-instrumented-method-typo branch from fde6491 to fe4428e Compare April 21, 2026 11:21
@alwx alwx requested a review from chargome April 21, 2026 11:22
Copy link
Copy Markdown
Member

@JPeer264 JPeer264 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing catch. Thx for fixing

@alwx alwx enabled auto-merge April 21, 2026 11:48
@alwx alwx merged commit 2fd74e9 into develop Apr 21, 2026
477 of 479 checks passed
@alwx alwx deleted the fix/google-genai-instrumented-method-typo branch April 21, 2026 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants