Skip to content

test(node-core): Fix minute-boundary race in session-aggregate tests #20437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicohrubec merged 1 commit into from
Apr 22, 2026
+55 −39
Merged

test(node-core): Fix minute-boundary race in session-aggregate tests #20437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions dev-packages/node-core-integration-tests/suites/sessions/errored-session-aggregate/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,17 @@ test('should aggregate successful, crashed and erroneous sessions', async () =>
.ignore('transaction', 'event')
.unignore('sessions')
.expect({
sessions: {
aggregates: [
{
started: expect.any(String),
exited: 2,
errored: 1,
},
],
sessions: agg => {
// Sessions are bucketed by minute; tolerate splits across a minute boundary by summing.
const totals = agg.aggregates.reduce(
(acc, b) => ({
exited: acc.exited + (b.exited ?? 0),
errored: acc.errored + (b.errored ?? 0),
crashed: acc.crashed + (b.crashed ?? 0),
}),
{ exited: 0, errored: 0, crashed: 0 },
);
expect(totals).toEqual({ exited: 2, errored: 1, crashed: 0 });
},
})
.start();
Expand Down
18 changes: 11 additions & 7 deletions dev-packages/node-core-integration-tests/suites/sessions/exited-session-aggregate/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,17 @@ test('should aggregate successful sessions', async () => {
.ignore('transaction', 'event')
.unignore('sessions')
.expect({
sessions: {
aggregates: [
{
started: expect.any(String),
exited: 3,
},
],
sessions: agg => {
// Sessions are bucketed by minute; tolerate splits across a minute boundary by summing.
const totals = agg.aggregates.reduce(
(acc, b) => ({
exited: acc.exited + (b.exited ?? 0),
errored: acc.errored + (b.errored ?? 0),
crashed: acc.crashed + (b.crashed ?? 0),
}),
{ exited: 0, errored: 0, crashed: 0 },
);
expect(totals).toEqual({ exited: 3, errored: 0, crashed: 0 });
},
})
.start();
Expand Down
19 changes: 11 additions & 8 deletions dev-packages/node-integration-tests/suites/sessions/crashed-session-aggregate/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,17 @@ test('should aggregate successful and crashed sessions', async () => {
.ignore('transaction', 'event')
.unignore('sessions')
.expect({
sessions: {
aggregates: [
{
started: expect.any(String),
exited: 2,
crashed: 1,
},
],
sessions: agg => {
// Sessions are bucketed by minute; tolerate splits across a minute boundary by summing.
const totals = agg.aggregates.reduce(
(acc, b) => ({
exited: acc.exited + (b.exited ?? 0),
errored: acc.errored + (b.errored ?? 0),
crashed: acc.crashed + (b.crashed ?? 0),
}),
{ exited: 0, errored: 0, crashed: 0 },
);
expect(totals).toEqual({ exited: 2, errored: 0, crashed: 1 });
},
})
.start();
Expand Down
20 changes: 11 additions & 9 deletions dev-packages/node-integration-tests/suites/sessions/errored-session-aggregate/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,17 @@ test('should aggregate successful, crashed and erroneous sessions', async () =>
.ignore('transaction', 'event')
.unignore('sessions')
.expect({
sessions: {
aggregates: [
{
started: expect.any(String),
exited: 1,
crashed: 1,
errored: 1,
},
],
sessions: agg => {
// Sessions are bucketed by minute; tolerate splits across a minute boundary by summing.
const totals = agg.aggregates.reduce(
(acc, b) => ({
exited: acc.exited + (b.exited ?? 0),
errored: acc.errored + (b.errored ?? 0),
crashed: acc.crashed + (b.crashed ?? 0),
}),
{ exited: 0, errored: 0, crashed: 0 },
);
expect(totals).toEqual({ exited: 1, errored: 1, crashed: 1 });
},
})
.start();
Expand Down
18 changes: 11 additions & 7 deletions dev-packages/node-integration-tests/suites/sessions/exited-session-aggregate/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,17 @@ test('should aggregate successful sessions', async () => {
.ignore('transaction', 'event')
.unignore('sessions')
.expect({
sessions: {
aggregates: [
{
started: expect.any(String),
exited: 3,
},
],
sessions: agg => {
// Sessions are bucketed by minute; tolerate splits across a minute boundary by summing.
const totals = agg.aggregates.reduce(
(acc, b) => ({
exited: acc.exited + (b.exited ?? 0),
errored: acc.errored + (b.errored ?? 0),
crashed: acc.crashed + (b.crashed ?? 0),
}),
{ exited: 0, errored: 0, crashed: 0 },
);
expect(totals).toEqual({ exited: 3, errored: 0, crashed: 0 });
},
})
.start();
Expand Down
Loading