fix: update prisma v7 spans descriptions#20456
Merged
Conversation
Co-Authored-By: Julien Blatecky <julien.blatecky@hey.com> Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
logaretm
force-pushed
the
awad/js-1451-support-prisma-v7-span-description
branch
from
c64446a to
3117350
Compare
Contributor
size-limit report 📦
|
Member
|
why don't we reopen their PR? Also I think I'd be better if we add an E2E test that uses prisma 7 |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Node Prisma tracing integration to keep span descriptions meaningful for Prisma ORM v7+, aligning behavior with existing v5/v6 handling and improving query visibility in traces.
Changes:
- Extend span renaming to also rewrite
prisma:client:db_queryspans (Prisma v7+) to the SQL query text. - Adjust the Prisma ORM v7 integration test to locate the DB span by
dbop/query attributes and assert the rewritten description.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/node/src/integrations/tracing/prisma.ts | Renames Prisma v7 prisma:client:db_query spans to use db.query.text as the span description (same as v5/v6). |
| dev-packages/node-integration-tests/suites/tracing/prisma-orm-v7/test.ts | Updates assertions to reflect the new rewritten DB span description for Prisma v7. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
@JPeer264 idk I already added them as a co-author. The included test already uses IRL prisma 7. |
JPeer264
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies the same fix as in #19924
closes #18797