fix(v8/profiling-node): Restore install script to build binaries from source#20517
Merged
andreiborza merged 1 commit intov8from Apr 27, 2026
Merged
Conversation
… source This PR adds the `install` script back compiles bindings from source if precompiled binaries are not found. We removed this in `8.55.1` when we fixed our CI to run on this legacy branch but v8 does not ship with a precompiled Node 24 binary. Users on Node 24 crash with `Cannot find module` errors. Closes: #20501
nicohrubec
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
installscript back compiles bindings from source if precompiled binaries are not found.We removed this in
8.55.1when we fixed our CI to run on this legacy branch but v8 does not ship with a precompiled Node 24 binary. Users on Node 24 crash withCannot find moduleerrors.It also fixes deprecation warnings for
spawnSynccalls and an interpolation error in the profiling integration console warning.Closes: #20501