Conversation
size-limit report 📦
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| span.name = name; | ||
| }, | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Feat PR missing integration or E2E test
Low Severity
This is a feat PR that migrates edge event processors to span-first APIs, including a new ignoreSpans configuration and a new processSegmentSpan hook. The diff only includes unit tests (enhanceMiddlewareRootSpan.test.ts and edgeSdk.test.ts). Per the project review rules, feat PRs need at least one integration or E2E test to verify the end-to-end behavior of the new span-first flow, especially for the streamed-span path which is entirely new functionality.
Additional Locations (1)
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 04e5262. Configure here.
…js-edge-event-processors
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7334e14. Configure here.
|
|
||
| expect(getName()).toBe('middleware CONNECT /foo'); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Missing integration or E2E test for feat PR
Low Severity
This feat PR only includes unit tests (enhanceMiddlewareRootSpan.test.ts and edgeSdk.test.ts) but no integration or E2E test. Per project rules, feat PRs are expected to include at least one integration or E2E test. While this is largely a migration of existing behavior, an integration test verifying the end-to-end middleware span name normalization on the edge runtime (covering both legacy and streamed paths) would help catch regressions.
Additional Locations (1)
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 7334e14. Configure here.
chargome
deleted the
cg/js-2209-event-processor-migration-nextjs-edge-event-processors
branch
2 participants
Basically #20527 but for edge
closes #20368