Skip to content

test(browser): Fix flaky loader test #20655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mydea wants to merge 1 commit into
base: develop
Choose a base branch
from
+3 −2
Open

test(browser): Fix flaky loader test #20655

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...ages/browser-integration-tests/loader-suites/loader/noOnLoad/sdkLoadedInMeanwhile/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,9 @@ sentryTest('it does not download the SDK if the SDK was loaded in the meanwhile'
// Still loaded the CDN bundle twice
await expect.poll(() => cdnLoadedCount, { timeout: 15_000 }).toBe(2);

// But only sent to Sentry once
expect(sentryEventCount).toBe(1);
// But only sent to Sentry once (`waitForErrorRequest` can resolve before the DSN
// `page.route` handler increments — poll until the intercept has run)
await expect.poll(() => sentryEventCount, { timeout: 15_000 }).toBe(1);

// Ensure loader does not overwrite init/config
const options = await page.evaluate(() => (window as any).Sentry.getClient()?.getOptions());
Expand Down
Loading