feat(core): Add applicationKey to BuildTimeOptionsBase#20789
Conversation
nicohrubec
left a comment
There was a problem hiding this comment.
the tanstack start sdk uses this type as well, should probably be wired in there too?
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 57ac005. Configure here.
| applicationKey: 'my-app-key', | ||
| }), | ||
| ); | ||
| }); |
There was a problem hiding this comment.
Missing integration or E2E test for new feature
Low Severity
This is a feat PR but only includes unit tests. Per the project review rules, feat PRs need at least one integration or E2E test. While the unit tests verify applicationKey option forwarding to the vite plugin, there's no integration or E2E test confirming the thirdPartyErrorFilterIntegration actually works end-to-end with the new top-level option in any of the wired-up frameworks.
Additional Locations (2)
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 57ac005. Configure here.


Adds a top-level
applicationKeyoption to the sharedBuildTimeOptionsBaseinterface, so users can configurethirdPartyErrorFilterIntegrationwithout needingunstable_*escape hatches.Wires up forwarding in:
Will do Next.js in a follow up as this does not implement the interface
closes #17384