Skip to content

feat(core): Add applicationKey to BuildTimeOptionsBase#20789

Merged
chargome merged 2 commits into
developfrom
chargome/feat/applicationkey-build-options
May 11, 2026
Merged

feat(core): Add applicationKey to BuildTimeOptionsBase#20789
chargome merged 2 commits into
developfrom
chargome/feat/applicationkey-build-options

Conversation

@chargome
Copy link
Copy Markdown
Member

Adds a top-level applicationKey option to the shared BuildTimeOptionsBase interface, so users can configure thirdPartyErrorFilterIntegration without needing unstable_* escape hatches.

Wires up forwarding in:

  • React Router
  • SvelteKit
  • Astro
  • Nuxt

Will do Next.js in a follow up as this does not implement the interface

closes #17384

@chargome chargome self-assigned this May 11, 2026
Copy link
Copy Markdown
Member

@nicohrubec nicohrubec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the tanstack start sdk uses this type as well, should probably be wired in there too?

@chargome chargome marked this pull request as ready for review May 11, 2026 10:24
@chargome chargome requested a review from a team as a code owner May 11, 2026 10:24
@chargome chargome requested a review from nicohrubec May 11, 2026 10:24
Copy link
Copy Markdown
Member

@nicohrubec nicohrubec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 57ac005. Configure here.

applicationKey: 'my-app-key',
}),
);
});
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing integration or E2E test for new feature

Low Severity

This is a feat PR but only includes unit tests. Per the project review rules, feat PRs need at least one integration or E2E test. While the unit tests verify applicationKey option forwarding to the vite plugin, there's no integration or E2E test confirming the thirdPartyErrorFilterIntegration actually works end-to-end with the new top-level option in any of the wired-up frameworks.

Additional Locations (2)
Fix in Cursor Fix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

Reviewed by Cursor Bugbot for commit 57ac005. Configure here.

@chargome chargome merged commit f7bdc4c into develop May 11, 2026
263 checks passed
@chargome chargome deleted the chargome/feat/applicationkey-build-options branch May 11, 2026 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

applicationKey does not exist in SentryReactRouterBuildOptions

2 participants