feat(core, node): portable Connect integration#20882
Open
isaacs wants to merge 1 commit into
Open
Conversation
isaacs
added a commit
that referenced
this pull request
May 13, 2026
Platform-portable Connect tracing integration in `@sentry/core` (`patchConnectModule`, `setupConnectErrorHandler`), similar to portable Express integration, and rewire the Node SDK's Connect integration to call into it through the otel InstrumentationBase class. Remove OTel-specific span attribute fix-up. Spans created with correct origin (`auto.http.connect`) and op directly in the middleware.
isaacs
force-pushed
the
isaacschlueter/portable-connect-integration
branch
from
051bd5b to
93b0b34
Compare
Platform-portable Connect tracing integration in `@sentry/core` (`patchConnectModule`, `setupConnectErrorHandler`), similar to portable Express integration, and rewire the Node SDK's Connect integration to call into it through the otel InstrumentationBase class. Remove OTel-specific span attribute fix-up. Spans created with correct origin (`auto.http.connect`) and op directly in the middleware.
isaacs
force-pushed
the
isaacschlueter/portable-connect-integration
branch
from
93b0b34 to
eebfaa1
Compare
Contributor
size-limit report 📦
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit eebfaa1. Configure here.
| // ['/api/', '/users', '/:id'] => '/api/users/:id' | ||
| function generateRoute(req: ConnectRequest): string { | ||
| const layers = getLayers(req); | ||
| /* v8 ignore start */ |
There was a problem hiding this comment.
Missing v8 ignore end suppresses file coverage
Low Severity
Two /* v8 ignore start */ directives (lines 128 and 227) have no matching /* v8 ignore end */. Since v8 coverage directives are line-based, the first one at line 128 causes the entire remainder of the file — including patchMiddleware, patchConnectApp, patchConnectModule, connectErrorMiddleware, and setupConnectErrorHandler — to be excluded from coverage reports. This silently hides untested code paths. These likely should be /* v8 ignore next */ for single-line guards instead.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit eebfaa1. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platform-portable Connect tracing integration in
@sentry/core(patchConnectModule,setupConnectErrorHandler), similar to portable Express integration, and rewire the Node SDK's Connect integration to call into it through the otel InstrumentationBase class.Remove OTel-specific span attribute fix-up. Spans created with correct origin (
auto.http.connect) and op directly in the middleware.