Skip to content

ref(nestjs): Vendor nestjs-core instrumentation#20996

Merged
nicohrubec merged 6 commits into
developfrom
nh/vendor-nestjs-core-instrumentation
May 20, 2026
Merged

ref(nestjs): Vendor nestjs-core instrumentation#20996
nicohrubec merged 6 commits into
developfrom
nh/vendor-nestjs-core-instrumentation

Conversation

@nicohrubec
Copy link
Copy Markdown
Member

@nicohrubec nicohrubec commented May 19, 2026

Vendors @opentelemetry/instrumentation-nestjs-core into the SDK with no logic changes. Types from @nestjs/core and @nestjs/common are inlined as simplified interfaces to avoid requiring these packages as dependencies.

Closes #20943

nicohrubec and others added 3 commits May 19, 2026 09:12
Closes #20515

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@nicohrubec nicohrubec marked this pull request as ready for review May 19, 2026 09:44
@nicohrubec nicohrubec requested a review from a team as a code owner May 19, 2026 09:44
nicohrubec and others added 2 commits May 19, 2026 15:17
Copy link
Copy Markdown
Member

@andreiborza andreiborza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super-l: Looks like OTel switched to SPDX identifiers for their licenses, saves some lines. We could do the same?

e.g.
https://github.com/open-telemetry/opentelemetry-js-contrib/blob/15ef7506553f631ea4181391e0c5725a56f0d082/packages/instrumentation-nestjs-core/src/index.ts#L1-L4

edit: also oxlint conflict

@nicohrubec
Copy link
Copy Markdown
Member Author

@andreiborza I'll leave the header as is for now so we keep it consistent, but will keep it in mind maybe we can shorten it in a follow-up

@nicohrubec nicohrubec merged commit 39fcbbc into develop May 20, 2026
269 checks passed
@nicohrubec nicohrubec deleted the nh/vendor-nestjs-core-instrumentation branch May 20, 2026 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vendor @opentelemetry/instrumentation-nestjs-core

2 participants