feat(hono): Instrument main-app inline middleware spans#20999
Merged
Conversation
s1gr1d
force-pushed
the
sig/hono-inline-middleware
branch
from
0dad338 to
32b0390
Compare
chargome
approved these changes
May 21, 2026
| */ | ||
| export function patchHttpMethodHandlers<E extends Env>(app: Hono<E>): void { | ||
| for (const method of HTTP_METHODS) { | ||
| app[method] = new Proxy(app[method], { |
Member
There was a problem hiding this comment.
l: For patchAppUse you prevented double wrapping with a check at this point
Member
Author
There was a problem hiding this comment.
We check for double wrapping in wrapMiddlewareWithSpan in line 24. The function is called by patchHttpMethodHandlers. But I'll add a test so we can be sure it produces only one span.
But for tidiness it's probably worth monitoring what was already patched, so we don't accumulate multiple proxy layers (even though those would still just create one span).
s1gr1d
force-pushed
the
sig/hono-inline-middleware
branch
from
32b0390 to
c58a52f
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Hono SDK already instruments
.use(for middleware) but not yet the HTTP method inline middleware.See more here: https://hono.dev/docs/guides/middleware#definition-of-middleware
This PR also adds some additional test cases for existing tests to make the tests more robust.