test(node): Fix flaky Anthropic integration test#21034
Merged
Merged
Conversation
This particular test was looking up the completion span by matching on `GEN_AI_INPUT_MESSAGES_ATTRIBUTE` which is not unique. Four spans have that same input message, with varying span ordering, the find lookup could match on the wrong span which lacked `max_tokens`. The fix is to find th espan by `GEN_AI_RESPONSE_ID_ATTRIBUTE` which identifies the span better. Closes: #21029
mydea
approved these changes
May 20, 2026
mydea
changed the title
mydea
changed the title
mydea
changed the title
nicohrubec
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This particular test was looking up the completion span by matching on
GEN_AI_INPUT_MESSAGES_ATTRIBUTEwhich is not unique. Four spans have that same input message, with varying span ordering, the find lookup could match on the wrong span which lackedmax_tokens.The fix is to find th espan by
GEN_AI_RESPONSE_ID_ATTRIBUTEwhich identifies the span better.Closes: #21029