Skip to content

feat(core): Migrate trpc to dataCollection #21072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chargome merged 2 commits into from
May 21, 2026
+8 −1
Merged

feat(core): Migrate trpc to dataCollection #21072

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0914f83
.
chargome May 20, 2026
0579e05
ayayay
chargome May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/core/src/trpc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ export function trpcMiddleware(options: SentryTrpcMiddlewareOptions = {}) {

const client = getClient();
const clientOptions = client?.getOptions();
const dataCollection = client?.getDataCollectionOptions();
Comment thread
chargome marked this conversation as resolved.

const trpcContext: Record<string, unknown> = {
procedure_path: path,
Expand All @@ -59,7 +60,11 @@ export function trpcMiddleware(options: SentryTrpcMiddlewareOptions = {}) {
(clientOptions?.normalizeDepth ?? 5), // 5 is a sane depth
);

if (options.attachRpcInput !== undefined ? options.attachRpcInput : clientOptions?.sendDefaultPii) {
if (
options.attachRpcInput !== undefined
? options.attachRpcInput
: dataCollection?.httpBodies.includes('incomingRequest')
) {
if (rawInput !== undefined) {
trpcContext.input = normalize(rawInput);
}
Expand Down
2 changes: 2 additions & 0 deletions packages/core/test/lib/trpc.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { type Client, setCurrentClient, type Span, trpcMiddleware } from '../../
import * as currentScopes from '../../src/currentScopes';
import * as exports from '../../src/exports';
import * as tracing from '../../src/tracing';
import { resolveDataCollectionOptions } from '../../src/utils/data-collection/resolveDataCollectionOptions';
import { getDefaultTestClientOptions, TestClient } from '../mocks/client';

describe('trpcMiddleware', () => {
Expand All @@ -13,6 +14,7 @@ describe('trpcMiddleware', () => {
normalizeDepth: 3,
sendDefaultPii: false,
}),
getDataCollectionOptions: vi.fn().mockReturnValue(resolveDataCollectionOptions({ sendDefaultPii: false })),
captureException: vi.fn(),
} as unknown as Client;

Expand Down
Loading