fix(astro): Avoid injecting meta tags into <head> inside attribute values#21089
Merged
andreiborza merged 1 commit intoMay 21, 2026
Merged
Conversation
…lues `addMetaTagToHead` previously used string replacement matching on `<head>` strings. This however also matches when `<head>` is used in data attribute values, e.g. `data-code="<head>..."`, corrupting the markup. We now use a regex that skips over quoted strings, so only a real `<head>` tag gets meta tags injected. Closes: #21068
andreiborza
requested review from
mydea and
s1gr1d
and removed request for
a team
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
andreiborza
requested review from
JPeer264 and
chargome
and removed request for
s1gr1d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addMetaTagToHeadpreviously used string replacement matching on<head>strings. This however also matches when<head>is used in data attribute values, e.g.data-code="<head>...", corrupting the markup.We now use a regex that skips over quoted strings, so only a real
<head>tag gets meta tags injected.Closes: #21068