ref(node): Vendor @opentelemetry/instrumentation-pg#21102
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
PgClient now matches the original pgTypes.Client shape (host, port, user, database, ssl, connection, etc.) instead of an invented shape. Revert connect patch to pass `this` directly as the original does. PgPool now includes all original Pool fields. QueryResult/QueryArrayResult keep oid, FieldDef, generics from originals. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
size-limit report 📦
|
With types:[], @types/node was only loaded because @types/pg (transitive dep of instrumentation-pg) had `/// <reference types="node" />`. Removing instrumentation-pg broke that chain. Explicitly including "node" in types reflects what any real Node.js consumer would have. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
nicohrubec
force-pushed
the
vendor-pg-instrumentation
branch
from
fb57f87 to
8df2e90
Compare
The app uses `process.env.NODE_ENV` directly, which requires @types/node. Previously resolved transitively via instrumentation-pg → @types/pg → @types/node. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
nicohrubec
requested review from
JPeer264 and
andreiborza
and removed request for
a team
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
andreiborza
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vendors
@opentelemetry/instrumentation-pg@0.70.0into the SDK with no logic changes. Types frompgandpg-poolare inlined as simplified interfaces to avoid requiring these packages as dependencies.Adds "node" to the types field in the
generic-ts3.8,generic-ts5.0andremix-hydrogenE2E test tsconfigs and adds@types/nodeas a devDependency inremix-hydrogen. These tests previously relied on@types/nodebeing loaded transitively via@opentelemetry/instrumentation-pg→@types/pg(which has/// <reference types="node" />). Now that this path no longer existstypes: []in the tsconfig results in these types not being available during the app build, because they get explicitly filtered.Closes #20158