fix(deno): support Deno.serve instrumentation on Deno 2.8#21155
Open
logaretm wants to merge 2 commits into
Open
fix(deno): support Deno.serve instrumentation on Deno 2.8#21155logaretm wants to merge 2 commits into
logaretm wants to merge 2 commits into
Conversation
logaretm
changed the title
logaretm
force-pushed
the
awad/js-2603-deno-280-compatibility
branch
3 times, most recently
from
1be0388 to
c7b8eb9
Compare
logaretm
force-pushed
the
awad/js-2603-deno-280-compatibility
branch
from
c7b8eb9 to
71a9c9f
Compare
logaretm
requested review from
JPeer264 and
andreiborza
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deno 2.8 changed the
serveto be a configurable property instead without a setter, so setting it directly crashes Deno apps.I have changed our serve instrumentation approach to use
Object.definePropertyto override it, while wrapping everything intry/catchto avoid crashing user apps in the future.I also added a couple of optional deno latest variants that would help us catch this in the future.
Fixes #21142