ref(node): Stop using registerSpanErrorInstrumentation() on server#21169
Merged
Conversation
mydea
force-pushed
the
fn/remove-server-error-span
branch
from
53a9eb2 to
c0f6a9e
Compare
Contributor
size-limit report 📦
|
mydea
force-pushed
the
fn/remove-server-error-span
branch
from
c0f6a9e to
163d0fa
Compare
mydea
force-pushed
the
fn/remove-server-error-span
branch
from
648b60d to
d1be7c0
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d1be7c0. Configure here.
mydea
requested review from
a team,
JPeer264,
Lms24 and
andreiborza
and removed request for
a team,
JPeer264 and
andreiborza
Lms24
reviewed
May 27, 2026
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
Sounds reasonable to me, though I had one question/concern. But apart from that it seems like no tests fail and the tests added demonstrate unchanged behavior.
| ); | ||
| }, | ||
| ).length; | ||
| const userProvidedListenersCount = global.process.listeners('uncaughtException').filter(listener => { |
Member
There was a problem hiding this comment.
hmm this change has me slightly suspicious because IIUC it implies that the registerSpanErrorInstrumentation() had an effect that we needed to skip here. Any idea why this might be? Could also just be a false flag and the tag condition just never made a difference...
Member
Author
There was a problem hiding this comment.
yeah also not sure, the code was here to handle the theoretical case where this would have worked but it hasn't - either it used to work differently back in the day, or it never worked - there was also not really test coverage for this as far as I can tell 😬
Lms24
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this does nothing on node, because the implementation of this calls this under the hood:
basically browser-only, using
window.onerror. I believe this is handled specifically in node anyhow so should not be used/needed and allows us to streamline this a bit and potentially move this to a browser-only place eventually.This also means we can remove the tag we put here, because this is actually not needed.
I adjusted a node-integration-test to verify this works there, both with using our own startSpan implementations (express uses this). With otel-native spans, it does not work, but it did not work before either - IMHO this is fine for the time being.