Skip to content

feat(remix): Migrate sendDefaultPii to dataCollection#21248

Merged
chargome merged 1 commit into
developfrom
cg/datacollection-remix
Jun 1, 2026
Merged

feat(remix): Migrate sendDefaultPii to dataCollection#21248
chargome merged 1 commit into
developfrom
cg/datacollection-remix

Conversation

@chargome
Copy link
Copy Markdown
Member

Replaces all sendDefaultPii usage in the Remix package with the new dataCollection option:

  • instrumentServer.ts: Passes client.getDataCollectionOptions() to httpHeadersToSpanAttributes
  • errors.ts: Gates action form data capture on dataCollection.httpBodies.includes('incomingRequest')
  • opentelemetry.ts: Gates OTel form data attributes on dataCollection.httpBodies.includes('incomingRequest')

The Remix-specific captureActionFormDataKeys option is preserved — only the gating mechanism changes.

closes #20933

@chargome chargome self-assigned this May 29, 2026
@chargome
Copy link
Copy Markdown
Member Author

chargome commented Jun 1, 2026

bugbot run

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 5a35431. Configure here.

Comment thread packages/remix/test/server/errors.test.ts
@chargome chargome marked this pull request as ready for review June 1, 2026 09:33
@chargome chargome requested a review from a team as a code owner June 1, 2026 09:33
@chargome chargome requested review from nicohrubec and s1gr1d and removed request for a team June 1, 2026 09:33
@chargome chargome merged commit 791fb4d into develop Jun 1, 2026
49 checks passed
@chargome chargome deleted the cg/datacollection-remix branch June 1, 2026 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(remix): Migrate remix to dataCollection

2 participants