Skip to content

test(nextjs): Remove assertion on conditional span#21329

Merged
chargome merged 1 commit into
developfrom
cg/next-clientcomponentloading
Jun 3, 2026
Merged

test(nextjs): Remove assertion on conditional span#21329
chargome merged 1 commit into
developfrom
cg/next-clientcomponentloading

Conversation

@chargome
Copy link
Copy Markdown
Member

@chargome chargome commented Jun 3, 2026

Next.js changed its internal timing so the clientComponentLoading span is no longer emitted. We just remove this brittle assertion as this was flaky already in the past.

closes #21314
closes #21315

@chargome chargome self-assigned this Jun 3, 2026
@chargome chargome marked this pull request as ready for review June 3, 2026 14:43
@chargome chargome merged commit 7271937 into develop Jun 3, 2026
51 checks passed
@chargome chargome deleted the cg/next-clientcomponentloading branch June 3, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nextjs-16 (canary-webpack) Test Failed nextjs-16 (canary) Test Failed

2 participants