Fix for errors without line numbers #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkonkle
added a commit
that referenced
this pull request
Feb 16, 2012
Fix for errors without line numbers
Contributor
|
Thanks! |
3 tasks
3 tasks
s1gr1d
added a commit
that referenced
this pull request
Jan 14, 2026
[Sentry changed IPs](https://status.sentry.io/incidents/qmh29yyv8bbv) and this caused problems with client report sending. The current problem is that client report sending is stuck in a loop if the client report itself cannot be sent: `Event fails → Client Report #1 fails → Client Report #2 fails → Client Report #3 fails → ∞` With this fix, failed client reports are not sent anymore to prevent this infinite feedback loop. The offline transport already drops client reports when they cannot be sent: https://github.com/getsentry/sentry-javascript/blob/1b41126666e27a311884cf6f7c1ef915f95477de/packages/core/src/transports/offline.ts#L83-L86 I tested this locally by adding an entry to `/etc/hosts`: `0.0.0.0 o1.ingest.sentry.io` (the example in the issue below) Closes #18802
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.