feat(nextjs): Client performance monitoring #3552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report
|
AbhiPrasad
reviewed
May 17, 2021
Member
AbhiPrasad
left a comment
AbhiPrasad
left a comment
There was a problem hiding this comment.
quick review to double check some stuff
packages/nextjs/src/index.client.ts
Outdated
| scope.setTag('runtime', 'browser'); | ||
| }); | ||
|
|
||
| startClientPerfMonitoring(); |
Member
There was a problem hiding this comment.
We should only do this if they have set tracesSampleRate in client options.
1 task
The order is determined by the exposed `wrapRouter` function. This function fills the router in the same order as Next.js docs, for clarity.
As the docstring say, wrapping `changeState` in the Router should be enough to get performance monitoring on the frontend. The previous approach was based on wrapping all the exposed Router methods users could use; but these are using the `changeState` underneath (it seems router actions always call it but not 100% about it, although it _may_ work implementing far less complexity). The approach and some code has been taken from https://github.com/getsentry/sentry-javascript/tree/abhi/next-client-names
Member
|
Ok, I added some preliminary tests by mocking out the next/router object, but they are mostly sanity checks. I think we shouldn't spend too much time on them, let's just focus on the end to end tests instead. Also, I couldn't get |
iker-barriocanal
changed the base branch from
master
to
kmclb-next-js-performance
AbhiPrasad
reviewed
May 20, 2021
AbhiPrasad
approved these changes
May 20, 2021
Member
AbhiPrasad
left a comment
AbhiPrasad
left a comment
There was a problem hiding this comment.
Think we are good after the variable name change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds front-end performance monitoring in the Next.js SDK, by providing a router instrumentation.