fix(nextjs): Check if public dir exists #3602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When instrumenting the nextjs server, we should check if the public directory exists.
kamilogorek
approved these changes
May 26, 2021
Contributor
size-limit report
|
lobsterkatie
approved these changes
May 26, 2021
Member
lobsterkatie
left a comment
lobsterkatie
left a comment
There was a problem hiding this comment.
LGTM!
I'm curious: did this actually break somewhere or is this just proactive?
Member
Author
|
This broke a test app when I installed the beta. |
Member
Author
|
This broke a test app when I installed the beta. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When instrumenting the nextjs server, we should check if the
public directory exists.
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).