-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
ref(all): Add support for exactOptionalPropertyTypes flag from TypeScript 4.4 #3960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b25d061 to
31ded8c
Compare
size-limit report
|
31ded8c to
61d3b4a
Compare
|
Should we use something like https://github.com/a-tarasyuk/eslint-plugin-redundant-undefined with the |
|
Oh, that would be much better |
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
|
Is there a status update on this? |
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
|
@lobsterkatie What's the status? 😬 |
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
|
Does Sentry not have maintainers? The silence isn't a good look... I'd love to get this in. |
|
Hey, sorry for the delay getting back to this! We kickstarted back up discussion about this internally - we will provide an update soon! |
|
Opened #4730 instead, as it'll be easier to start it from scratch than rebase over 8mo old PR :P |
Cherry-picked commits from
#3958
#3959
with
NodeOptionsupdated as well.We might still need/want to update all integrations, handlers, and specific frameworks (
NextjsOptions,VueOptions). But it's a good start.