build: Extract typescript pkg into main package.json#4242
Conversation
AbhiPrasad
requested review from
a team,
iker-barriocanal and
rhcarvalho
and removed request for
a team
size-limit report
|
AbhiPrasad
force-pushed
the
abhi-package-json-typescript
branch
from
0b0e109 to
eb2feba
Compare
| "devDependencies": { | ||
| "typescript": "3.7.5" | ||
| }, | ||
| "devDependencies": {}, |
There was a problem hiding this comment.
| "devDependencies": {}, |
?
There was a problem hiding this comment.
Yeah this is because I just find and replaced the value. I can update.
There was a problem hiding this comment.
Actually I'm going to leave it like this. This makes makes the diff when adding new packages much cleaner (which in turn makes git blame easier to understand in the future)
rhcarvalho
left a comment
rhcarvalho
left a comment
There was a problem hiding this comment.
Isn't this change going to make it harder to work on single packages in isolation? (In particular because certain requirements become implicit/defined elsewhere).
One of the supposed advantages of having multiple packages is not being forced to upgrade everything in lock step. If we do this change, I imagine will be in a situation of all or nothing when trying to upgrade common dependencies including typescript version.
|
We use a common tsconfig for all of our packages, so having inconsistent typescript versions will lead to problems. In addition, certain packages having different versions than others can cause problems. Having a single source of truth (the main package.json) is easier maintence wise. typescript (because of the variety of issues it introduces), should for sure be an all or nothing change - a common dependency. Having these spread out just create potential for problems or inconsistencies.
No, because yarn workspaces should take care of everything being resolved correctly. |
AbhiPrasad
force-pushed
the
abhi-package-json-typescript
branch
from
eb2feba to
7e1cf0f
Compare
3 participants
As prep for unifying our package.json, let's move dependencies that every package uses into the root
package.json.This patch does that for the
typescriptpackage.