Prevent reentrancy in isSetup() when used in log method #472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling isSetup from within a log method before Raven is setup can cause Raven to enter an reentrant flow. Set the `raventNotConfiguredError` flag early to limit reentrances to 1.
benvinegar
added a commit
that referenced
this pull request
Jan 15, 2016
Prevent reentrancy in isSetup() when used in log method
Contributor
|
Thanks @mseeley! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raven.isSetup()logs an error the first time it's called when Raven is not configured. ThelogDebugmethod assumes the methods cached at initialization time are the built-in methods.It's possible to send
Raven.isSetup()into a reentrant loop if a few things happen:console.errormethod callsRaven.isSetup().Repro: https://gist.github.com/mseeley/c6243d39a77e54a17ff1
Super edgy but not difficult to trigger if you're holding it a little crooked. Although since avoiding excessive reentrancy is a one liner I figured you all might take the patch.
Thanks!