Skip to content

Conversation

@dcramer
Copy link
Member

@dcramer dcramer commented Jul 28, 2016

This change is Reviewable

@dcramer
Copy link
Member Author

dcramer commented Jul 28, 2016

Getting some odd behavior when doing this, and don't have time atm to figure out why/what is going on.

@stayallive
Copy link
Collaborator

stayallive commented Jul 29, 2016

What is the odd behavior you are experiencing?

Also if you use a blade view you should actually use the blade syntax 😉 Otherwise you should drop the .blade from the filename.

Here the code with blade tags.

@unless(empty($sentryID))
    <!-- Sentry JS SDK 2.1.+ required -->
    <script src="https://cdn.ravenjs.com/3.3.0/raven.min.js"></script>

    <script>
        Raven.showReportDialog({
            eventId: '{{ $sentryID }}',

            // use the public DSN (dont include your secret!)
            dsn: 'https://e9ebbd88548a441288393c457ec90441@app.getsentry.com/3235',

            user: {
                'name':  'Jane Doe',
                'email': 'jane.doe@example.com',
            }
        });
    </script>
@endunless

@dcramer
Copy link
Member Author

dcramer commented Jul 29, 2016

php artisan clear-compiled seems to have resolved it

@dcramer dcramer force-pushed the example/feedback branch from b15f61e to 509dad0 Compare July 29, 2016 15:47
@dcramer dcramer merged commit ec33006 into master Jul 29, 2016
@dcramer dcramer deleted the example/feedback branch July 29, 2016 15:47
@dcramer
Copy link
Member Author

dcramer commented Jul 29, 2016

@stayallive https://blog.getsentry.com/2016/07/29/user-feedback-in-laravel.html

weirdly in my test env I see the a duplicated error message, but I'm pretty sure we've got the implementation 'correct'. lmk if you have thoughts otherwise

@stayallive
Copy link
Collaborator

@dcramer: Freshly installed and configured the L5.2 example and it works flawless (also looks almost identical to how I am running it in production for several apps)!

The example in the blogpost is missing the eventId: {{ $sentryID }}, in the blade example (set to empty string there).

@dcramer
Copy link
Member Author

dcramer commented Jul 29, 2016

Doh, Jekyll template is evaluating the block, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants