Skip to content

Conversation

@hackel
Copy link
Contributor

@hackel hackel commented Nov 30, 2016

This is a fix for #24. I used a public static property so that you can also do this:

class SentryFacade extends Facade
{
    protected static function getFacadeAccessor()
    {
        return SentryLaravelServiceProvider::$abstract;
    }
}

@dcramer
Copy link
Member

dcramer commented Dec 9, 2016

@hackel I'm going to merge this in, but what are your thoughts on making the default Facade be this type but titlecase?

@dcramer dcramer merged commit 9260463 into getsentry:master Dec 9, 2016
@hackel
Copy link
Contributor Author

hackel commented Dec 13, 2016

@dcramer I think that makes sense. I tried to change as little as possible to make it work. I don't generally use facades myself. We could create the facade alias manually:

if ($this->app['config']->get('auto_create_alias', true)) {
    \Illuminate\Foundation\AliasLoader::getInstance()->alias(studly_case(static::$abstract), SentryFacade::class);
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants