-
-
Notifications
You must be signed in to change notification settings - Fork 202
Add starfish v1 attributes to span data/breadcrumbs #764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6c79269 to
ec39d09
Compare
| 'request_body_size' => $event->request->toPsrRequest()->getBody()->getSize(), | ||
| 'http.request.body.size' => $event->request->toPsrRequest()->getBody()->getSize(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a response recieved we do not duplicate them but removed the old names. Should we here too? Also they can be null should we then not include them at all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was an oversight, removed!
Hmm, good question, @AbhiPrasad ? 😬
|
Are there also standards for how http.server transactions are tagged? I noticed that laravel and symfony do it a bit differently. |
We have some, but they are sparse. If you create a GH issue with the inconsistencies we can take a look and audit. |
Not sure where to open an issue, but in
url and method are set as data, while in https://github.com/getsentry/sentry-symfony/blob/3e9e23da8985818872cf91e5d5d59895a1421154/src/EventListener/TracingRequestListener.php#L89 http.url and http.method are set as tags.
|
|
Moving forward, we'll remove tags set by the SDK and rely on request/response context and span data instead. |
AbhiPrasad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
Closes #765
See https://github.com/open-telemetry/opentelemetry-specification/tree/main/specification/trace/semantic_conventions