Skip to content

Conversation

@dcramer
Copy link
Member

@dcramer dcramer commented Jun 27, 2025

Add warning log when documentation search returns no results to help identify potential issues with search queries or guide filters.

🤖 Generated with Claude Code

Add warning log when documentation search returns no results to help
identify potential issues with search queries or guide filters.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@codecov
Copy link

codecov bot commented Jun 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.12%. Comparing base (d39b04f) to head (07a95e3).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #319      +/-   ##
==========================================
- Coverage   64.26%   64.12%   -0.15%     
==========================================
  Files          48       46       -2     
  Lines        5709     5608     -101     
  Branches      476      471       -5     
==========================================
- Hits         3669     3596      -73     
+ Misses       2040     2012      -28     
Flag Coverage Δ
evals ?
unittests 64.12% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dcramer dcramer marked this pull request as ready for review June 27, 2025 17:54
@dcramer dcramer merged commit 48e08cb into main Jun 27, 2025
10 checks passed
@dcramer dcramer deleted the feat/log-empty-searches branch June 27, 2025 17:54
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Search Warning Fails for Undefined or Null Data

The warning for no search results only triggers when searchData.data is an empty array. It should also trigger when searchData.data is undefined or null, as these also represent no results and are handled as such by the subsequent result processing.

packages/mcp-cloudflare/src/server/routes/search.ts#L156-L157

if (searchData.data?.length === 0) {

Fix in Cursor


Was this report helpful? Give feedback by reacting with 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants